From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/i915: use for_each_intel_connector_iter in intel_display.c
Date: Wed, 21 Dec 2016 11:01:49 +0100 [thread overview]
Message-ID: <01ccf029-376f-6153-be07-d3b0103ad82d@linux.intel.com> (raw)
In-Reply-To: <20161220182905.ttrzxruyzsarzoj7@phenom.ffwll.local>
Op 20-12-16 om 19:29 schreef Daniel Vetter:
> On Mon, Dec 19, 2016 at 10:47:25AM +0100, Maarten Lankhorst wrote:
>> Op 19-12-16 om 10:22 schreef Daniel Vetter:
>>> On Mon, Dec 19, 2016 at 09:58:28AM +0100, Daniel Vetter wrote:
>>>> This gets rid of the last users of for_each_intel_connector(), remove
>>>> that too.
>>>>
>>>> The one exception is the loop in verify_encoder_state - that needs to
>>>> switch over to for_each_connector_in_state.
>>>>
>>>> v2: Maarten corrected me that in the state verifier we indeed must
>>>> only walk connectors in the atomic commit, not all of them!
>>> Ok, CI just told me this was a stupid idea. Since we don't walk all
>>> connectors, but still walk all encoders there's not plenty of state
>>> mismatches (e.g. if you have 2 crtc with different connectors enabled and
>>> you're doing a modeset on just one).
>>>
>>> Not exactly sure how to best fix this, since replacing the encoder
>>> walking with a connnector walking and then dereferencing
>>> connector->state->best_encoder to get at only the encoders relevant for us
>>> defeats the point of the cross check.
>> Assuming we trust the atomic state, we could fix this by iterating either state and ORing (old,new)_crtc_state->encoder_mask.
>> This way we'll have all encoders that we care about.
> Yeah, I think we have to rely on the correctness of the atomic states. For
> merging I think it's better to get v1 in to correct the connector_list
> enumeration, then fix up the encoder checking in a separate patch on top.
> Does that sound good?
Yes sounds good.
~Maarten
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-21 10:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 8:24 [PATCH 1/6] drm/i915: Use drm_connector_list_iter in debugfs Daniel Vetter
2016-12-19 8:24 ` [PATCH 2/6] drm/i915: use drm_connector_list_iter in intel_hotplug.c Daniel Vetter
2016-12-20 13:32 ` Maarten Lankhorst
2016-12-19 8:24 ` [PATCH 3/6] drm/i915: use drm_connector_list_iter in intel_opregion.c Daniel Vetter
2016-12-20 13:57 ` Daniel Vetter
2016-12-19 8:24 ` [PATCH 4/6] drm/i915: Make intel_get_pipe_from_connector atomic Daniel Vetter
2016-12-20 13:35 ` Maarten Lankhorst
2016-12-20 13:49 ` Daniel Vetter
2016-12-21 14:09 ` Maarten Lankhorst
2016-12-19 8:24 ` [PATCH 5/6] drm/i915: use for_each_intel_connector_iter in intel_display.c Daniel Vetter
2016-12-19 8:58 ` [PATCH] " Daniel Vetter
2016-12-19 9:22 ` Daniel Vetter
2016-12-19 9:47 ` Maarten Lankhorst
2016-12-20 18:29 ` Daniel Vetter
2016-12-21 10:01 ` Maarten Lankhorst [this message]
2016-12-19 8:24 ` [PATCH 6/6] drm/i915: Update comment that sets I915_MODE_FLAG_INHERITED Daniel Vetter
2016-12-20 13:38 ` Maarten Lankhorst
2016-12-21 10:24 ` Daniel Vetter
2016-12-19 8:45 ` ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915: Use drm_connector_list_iter in debugfs Patchwork
2016-12-19 9:15 ` ✗ Fi.CI.BAT: warning for series starting with [1/6] drm/i915: Use drm_connector_list_iter in debugfs (rev2) Patchwork
2016-12-20 12:38 ` [PATCH 1/6] drm/i915: Use drm_connector_list_iter in debugfs Maarten Lankhorst
2016-12-20 13:59 ` [PATCH] " Daniel Vetter
2016-12-20 16:15 ` ✗ Fi.CI.BAT: warning for series starting with drm/i915: Use drm_connector_list_iter in debugfs (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01ccf029-376f-6153-be07-d3b0103ad82d@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox