From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 14/37] drm/i915: Refactor export_fence()
 after i915_vma_move_to_active()
Date: Fri, 29 Jun 2018 13:00:26 +0100
Message-ID: <01d67f96-0bb9-2cd0-d176-1d024d1257a9@linux.intel.com>
References: <20180629075348.27358-1-chris@chris-wilson.co.uk>
 <20180629075348.27358-14-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 5CAA46F0B2
 for <intel-gfx@lists.freedesktop.org>; Fri, 29 Jun 2018 12:00:28 +0000 (UTC)
In-Reply-To: <20180629075348.27358-14-chris@chris-wilson.co.uk>
Content-Language: en-GB
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDI5LzA2LzIwMTggMDg6NTMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBDdXJyZW50bHkgYWxs
IGNhbGxlcnMgYXJlIHJlc3BvbnNpYmxlIGZvciBhZGRpbmcgdGhlIHZtYSB0byB0aGUgYWN0aXZl
Cj4gdGltZWxpbmUgYW5kIHRoZW4gZXhwb3J0aW5nIGl0cyBmZW5jZS4gQ29tYmluZSB0aGUgdHdv
IG9wZXJhdGlvbnMgaW50bwo+IGk5MTVfdm1hX21vdmVfdG9fYWN0aXZlKCkgdG8gbW92ZSBhbGwg
dGhlIGV4dHJhIGhhbmRsaW5nIGZyb20gdGhlCj4gY2FsbGVycyB0byB0aGUgc2luZ2xlIHNpdGUu
Cj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u
dWs+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMg
ICAgfCA0NyArKysrKysrKystLS0tLS0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxm
dGVzdHMvaHVnZV9wYWdlcy5jICAgfCAgNCAtLQo+ICAgLi4uL2RybS9pOTE1L3NlbGZ0ZXN0cy9p
OTE1X2dlbV9jb2hlcmVuY3kuYyAgIHwgIDQgLS0KPiAgIC4uLi9ncHUvZHJtL2k5MTUvc2VsZnRl
c3RzL2k5MTVfZ2VtX2NvbnRleHQuYyB8ICA0IC0tCj4gICA0IGZpbGVzIGNoYW5nZWQsIDIxIGlu
c2VydGlvbnMoKyksIDM4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X2dlbV9leGVjYnVmZmVyLmMKPiBpbmRleCBjMmRkOWI0Y2RhY2UuLjkxZjIwNDQ1MTQ3ZiAx
MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMK
PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9leGVjYnVmZmVyLmMKPiBAQCAt
MTE2NiwxNSArMTE2Niw5IEBAIHN0YXRpYyBpbnQgX19yZWxvY19ncHVfYWxsb2Moc3RydWN0IGk5
MTVfZXhlY2J1ZmZlciAqZWIsCj4gICAKPiAgIAlHRU1fQlVHX09OKCFyZXNlcnZhdGlvbl9vYmpl
Y3RfdGVzdF9zaWduYWxlZF9yY3UoYmF0Y2gtPnJlc3YsIHRydWUpKTsKPiAgIAlpOTE1X3ZtYV9t
b3ZlX3RvX2FjdGl2ZShiYXRjaCwgcnEsIDApOwo+IC0JcmVzZXJ2YXRpb25fb2JqZWN0X2xvY2so
YmF0Y2gtPnJlc3YsIE5VTEwpOwo+IC0JcmVzZXJ2YXRpb25fb2JqZWN0X2FkZF9leGNsX2ZlbmNl
KGJhdGNoLT5yZXN2LCAmcnEtPmZlbmNlKTsKPiAtCXJlc2VydmF0aW9uX29iamVjdF91bmxvY2so
YmF0Y2gtPnJlc3YpOwoKSGVyZSBub3cgdGhlIGV4Y2x1c2l2ZSBmZW5jZSBpcyBub3QgYWRkZWQg
YW55IG1vcmUgZHVlIGZsYWdzIGJlaW5nIHplcm8uCgo+ICAgCWk5MTVfdm1hX3VucGluKGJhdGNo
KTsKPiAgIAo+ICAgCWk5MTVfdm1hX21vdmVfdG9fYWN0aXZlKHZtYSwgcnEsIEVYRUNfT0JKRUNU
X1dSSVRFKTsKPiAtCXJlc2VydmF0aW9uX29iamVjdF9sb2NrKHZtYS0+cmVzdiwgTlVMTCk7Cj4g
LQlyZXNlcnZhdGlvbl9vYmplY3RfYWRkX2V4Y2xfZmVuY2Uodm1hLT5yZXN2LCAmcnEtPmZlbmNl
KTsKPiAtCXJlc2VydmF0aW9uX29iamVjdF91bmxvY2sodm1hLT5yZXN2KTsKPiAgIAo+ICAgCXJx
LT5iYXRjaCA9IGJhdGNoOwo+ICAgCj4gQEAgLTE3NzEsMjUgKzE3NjUsNiBAQCBzdGF0aWMgaW50
IGViX3JlbG9jYXRlKHN0cnVjdCBpOTE1X2V4ZWNidWZmZXIgKmViKQo+ICAgCXJldHVybiBlYl9y
ZWxvY2F0ZV9zbG93KGViKTsKPiAgIH0KPiAgIAo+IC1zdGF0aWMgdm9pZCBlYl9leHBvcnRfZmVu
Y2Uoc3RydWN0IGk5MTVfdm1hICp2bWEsCj4gLQkJCSAgICBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpy
cSwKPiAtCQkJICAgIHVuc2lnbmVkIGludCBmbGFncykKPiAtewo+IC0Jc3RydWN0IHJlc2VydmF0
aW9uX29iamVjdCAqcmVzdiA9IHZtYS0+cmVzdjsKPiAtCj4gLQkvKgo+IC0JICogSWdub3JlIGVy
cm9ycyBmcm9tIGZhaWxpbmcgdG8gYWxsb2NhdGUgdGhlIG5ldyBmZW5jZSwgd2UgY2FuJ3QKPiAt
CSAqIGhhbmRsZSBhbiBlcnJvciByaWdodCBub3cuIFdvcnN0IGNhc2Ugc2hvdWxkIGJlIG1pc3Nl
ZAo+IC0JICogc3luY2hyb25pc2F0aW9uIGxlYWRpbmcgdG8gcmVuZGVyaW5nIGNvcnJ1cHRpb24u
Cj4gLQkgKi8KPiAtCXJlc2VydmF0aW9uX29iamVjdF9sb2NrKHJlc3YsIE5VTEwpOwo+IC0JaWYg
KGZsYWdzICYgRVhFQ19PQkpFQ1RfV1JJVEUpCj4gLQkJcmVzZXJ2YXRpb25fb2JqZWN0X2FkZF9l
eGNsX2ZlbmNlKHJlc3YsICZycS0+ZmVuY2UpOwo+IC0JZWxzZSBpZiAocmVzZXJ2YXRpb25fb2Jq
ZWN0X3Jlc2VydmVfc2hhcmVkKHJlc3YpID09IDApCj4gLQkJcmVzZXJ2YXRpb25fb2JqZWN0X2Fk
ZF9zaGFyZWRfZmVuY2UocmVzdiwgJnJxLT5mZW5jZSk7Cj4gLQlyZXNlcnZhdGlvbl9vYmplY3Rf
dW5sb2NrKHJlc3YpOwo+IC19Cj4gLQo+ICAgc3RhdGljIGludCBlYl9tb3ZlX3RvX2dwdShzdHJ1
Y3QgaTkxNV9leGVjYnVmZmVyICplYikKPiAgIHsKPiAgIAljb25zdCB1bnNpZ25lZCBpbnQgY291
bnQgPSBlYi0+YnVmZmVyX2NvdW50Owo+IEBAIC0xODQ0LDcgKzE4MTksNiBAQCBzdGF0aWMgaW50
IGViX21vdmVfdG9fZ3B1KHN0cnVjdCBpOTE1X2V4ZWNidWZmZXIgKmViKQo+ICAgCQlzdHJ1Y3Qg
aTkxNV92bWEgKnZtYSA9IGViLT52bWFbaV07Cj4gICAKPiAgIAkJaTkxNV92bWFfbW92ZV90b19h
Y3RpdmUodm1hLCBlYi0+cmVxdWVzdCwgZmxhZ3MpOwo+IC0JCWViX2V4cG9ydF9mZW5jZSh2bWEs
IGViLT5yZXF1ZXN0LCBmbGFncyk7Cj4gICAKPiAgIAkJX19lYl91bnJlc2VydmVfdm1hKHZtYSwg
ZmxhZ3MpOwo+ICAgCQl2bWEtPmV4ZWNfZmxhZ3MgPSBOVUxMOwo+IEBAIC0xODg0LDYgKzE4NTgs
MjUgQEAgc3RhdGljIGJvb2wgaTkxNV9nZW1fY2hlY2tfZXhlY2J1ZmZlcihzdHJ1Y3QgZHJtX2k5
MTVfZ2VtX2V4ZWNidWZmZXIyICpleGVjKQo+ICAgCXJldHVybiB0cnVlOwo+ICAgfQo+ICAgCj4g
K3N0YXRpYyB2b2lkIGV4cG9ydF9mZW5jZShzdHJ1Y3QgaTkxNV92bWEgKnZtYSwKPiArCQkJIHN0
cnVjdCBpOTE1X3JlcXVlc3QgKnJxLAo+ICsJCQkgdW5zaWduZWQgaW50IGZsYWdzKQo+ICt7Cj4g
KwlzdHJ1Y3QgcmVzZXJ2YXRpb25fb2JqZWN0ICpyZXN2ID0gdm1hLT5yZXN2Owo+ICsKPiArCS8q
Cj4gKwkgKiBJZ25vcmUgZXJyb3JzIGZyb20gZmFpbGluZyB0byBhbGxvY2F0ZSB0aGUgbmV3IGZl
bmNlLCB3ZSBjYW4ndAo+ICsJICogaGFuZGxlIGFuIGVycm9yIHJpZ2h0IG5vdy4gV29yc3QgY2Fz
ZSBzaG91bGQgYmUgbWlzc2VkCj4gKwkgKiBzeW5jaHJvbmlzYXRpb24gbGVhZGluZyB0byByZW5k
ZXJpbmcgY29ycnVwdGlvbi4KPiArCSAqLwo+ICsJcmVzZXJ2YXRpb25fb2JqZWN0X2xvY2socmVz
diwgTlVMTCk7Cj4gKwlpZiAoZmxhZ3MgJiBFWEVDX09CSkVDVF9XUklURSkKPiArCQlyZXNlcnZh
dGlvbl9vYmplY3RfYWRkX2V4Y2xfZmVuY2UocmVzdiwgJnJxLT5mZW5jZSk7Cj4gKwllbHNlIGlm
IChyZXNlcnZhdGlvbl9vYmplY3RfcmVzZXJ2ZV9zaGFyZWQocmVzdikgPT0gMCkKPiArCQlyZXNl
cnZhdGlvbl9vYmplY3RfYWRkX3NoYXJlZF9mZW5jZShyZXN2LCAmcnEtPmZlbmNlKTsKPiArCXJl
c2VydmF0aW9uX29iamVjdF91bmxvY2socmVzdik7Cj4gK30KPiArCj4gICB2b2lkIGk5MTVfdm1h
X21vdmVfdG9fYWN0aXZlKHN0cnVjdCBpOTE1X3ZtYSAqdm1hLAo+ICAgCQkJICAgICBzdHJ1Y3Qg
aTkxNV9yZXF1ZXN0ICpycSwKPiAgIAkJCSAgICAgdW5zaWduZWQgaW50IGZsYWdzKQo+IEBAIC0x
OTIxLDYgKzE5MTQsOCBAQCB2b2lkIGk5MTVfdm1hX21vdmVfdG9fYWN0aXZlKHN0cnVjdCBpOTE1
X3ZtYSAqdm1hLAo+ICAgCj4gICAJaWYgKGZsYWdzICYgRVhFQ19PQkpFQ1RfTkVFRFNfRkVOQ0Up
Cj4gICAJCWk5MTVfZ2VtX2FjdGl2ZV9zZXQoJnZtYS0+bGFzdF9mZW5jZSwgcnEpOwo+ICsKPiAr
CWV4cG9ydF9mZW5jZSh2bWEsIHJxLCBmbGFncyk7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyBpbnQg
aTkxNV9yZXNldF9nZW43X3NvbF9vZmZzZXRzKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxKQo+IGRp
ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaHVnZV9wYWdlcy5jIGIv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2h1Z2VfcGFnZXMuYwo+IGluZGV4IGI1ZTg3
ZmNkY2RhZS4uMzU4ZmM4MWY2Yzk5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L3NlbGZ0ZXN0cy9odWdlX3BhZ2VzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxm
dGVzdHMvaHVnZV9wYWdlcy5jCj4gQEAgLTk5OCwxMCArOTk4LDYgQEAgc3RhdGljIGludCBncHVf
d3JpdGUoc3RydWN0IGk5MTVfdm1hICp2bWEsCj4gICAKPiAgIAlpOTE1X3ZtYV9tb3ZlX3RvX2Fj
dGl2ZSh2bWEsIHJxLCBFWEVDX09CSkVDVF9XUklURSk7Cj4gICAKPiAtCXJlc2VydmF0aW9uX29i
amVjdF9sb2NrKHZtYS0+cmVzdiwgTlVMTCk7Cj4gLQlyZXNlcnZhdGlvbl9vYmplY3RfYWRkX2V4
Y2xfZmVuY2Uodm1hLT5yZXN2LCAmcnEtPmZlbmNlKTsKPiAtCXJlc2VydmF0aW9uX29iamVjdF91
bmxvY2sodm1hLT5yZXN2KTsKPiAtCj4gICBlcnJfcmVxdWVzdDoKPiAgIAlpOTE1X3JlcXVlc3Rf
YWRkKHJxKTsKPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVz
dHMvaTkxNV9nZW1fY29oZXJlbmN5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMv
aTkxNV9nZW1fY29oZXJlbmN5LmMKPiBpbmRleCBhNDkwMDA5MWFlM2QuLjExNDI3YWFlMDg1MyAx
MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaTkxNV9nZW1fY29o
ZXJlbmN5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaTkxNV9nZW1f
Y29oZXJlbmN5LmMKPiBAQCAtMjI1LDEwICsyMjUsNiBAQCBzdGF0aWMgaW50IGdwdV9zZXQoc3Ry
dWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPiAgIAlpOTE1X3ZtYV9tb3ZlX3RvX2FjdGl2
ZSh2bWEsIHJxLCBFWEVDX09CSkVDVF9XUklURSk7Cj4gICAJaTkxNV92bWFfdW5waW4odm1hKTsK
PiAgIAo+IC0JcmVzZXJ2YXRpb25fb2JqZWN0X2xvY2sob2JqLT5yZXN2LCBOVUxMKTsKPiAtCXJl
c2VydmF0aW9uX29iamVjdF9hZGRfZXhjbF9mZW5jZShvYmotPnJlc3YsICZycS0+ZmVuY2UpOwo+
IC0JcmVzZXJ2YXRpb25fb2JqZWN0X3VubG9jayhvYmotPnJlc3YpOwo+IC0KPiAgIAlpOTE1X3Jl
cXVlc3RfYWRkKHJxKTsKPiAgIAo+ICAgCXJldHVybiAwOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvaTkxNV9nZW1fY29udGV4dC5jIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvc2VsZnRlc3RzL2k5MTVfZ2VtX2NvbnRleHQuYwo+IGluZGV4IDMxNjliNzIxODBk
MC4uYTc4ZjhiZGI4MjIyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0
ZXN0cy9pOTE1X2dlbV9jb250ZXh0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxm
dGVzdHMvaTkxNV9nZW1fY29udGV4dC5jCj4gQEAgLTE3OSwxMCArMTc5LDYgQEAgc3RhdGljIGlu
dCBncHVfZmlsbChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+ICAgCWk5MTVfdm1h
X21vdmVfdG9fYWN0aXZlKHZtYSwgcnEsIDApOwo+ICAgCWk5MTVfdm1hX3VucGluKHZtYSk7Cj4g
ICAKPiAtCXJlc2VydmF0aW9uX29iamVjdF9sb2NrKG9iai0+cmVzdiwgTlVMTCk7Cj4gLQlyZXNl
cnZhdGlvbl9vYmplY3RfYWRkX2V4Y2xfZmVuY2Uob2JqLT5yZXN2LCAmcnEtPmZlbmNlKTsKCkhl
cmUgYXMgd2VsbCB0aGlzIHdvbid0IGJlIGFkZGVkIGR1ZSB6ZXJvIGZsYWdzLgoKPiAtCXJlc2Vy
dmF0aW9uX29iamVjdF91bmxvY2sob2JqLT5yZXN2KTsKPiAtCj4gICAJaTkxNV9yZXF1ZXN0X2Fk
ZChycSk7Cj4gICAKPiAgIAlyZXR1cm4gMDsKPiAKClRoZXJlIGlzIG9uZSBpOTE1X3ZtYV9tb3Zl
X3RvX2FjdGl2ZSBpbiByZW5kZXIgc3RhdGUgYW5kIG9uZSBpbiBndnQgCndoaWNoIHdpbGwgbm93
IGhhdmUgc29tZSBleHRyYSBwcm9jZXNzaW5nL2FsbG9jYXRpb25zLCBkbyB3ZSBjYXJlPwoKUmVn
YXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v
cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n
ZngK