intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Tvrtko Ursulin <tursulin@ursulin.net>,
	Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Unpin vma iomapping when fbdev is destroyed
Date: Tue, 4 Jul 2017 12:26:31 +0100	[thread overview]
Message-ID: <0413339d-e777-2f6c-989b-e64d5190bac2@linux.intel.com> (raw)
In-Reply-To: <149916343499.4151.11988696390121141030@mail.alporthouse.com>


On 04/07/2017 11:17, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2017-07-04 10:46:40)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> If we don't release the iomapping we are not able to unpin the
>> vma which then gets leaked.
> 
> Oh, we still do unpin the vma on closing the object and we don't hold
> any extra object reference for the iomap. It is still a good patch for
> the symmetry, except it doesn't do what you say :-)

What do you mean that we don't hold any extra reference for the iomap? I 
see i915_vma_pin_iomap -> __i915_vma_pin -> vma->flags++. I can't spot 
the place which would override this and still unbind it at some point.

>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> ---
>> Some time last year we talked about a pending patch to get rid
>> of the fbdev VMA leak. I lost track of what happened with that.
> 
> That was fixed by the intel_unpin_fb_vma() in there.

I suppose I don't see how since I don't see what defeats the elevated 
pin count from the above.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-07-04 11:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-04  9:46 [PATCH] drm/i915: Unpin vma iomapping when fbdev is destroyed Tvrtko Ursulin
2017-07-04 10:05 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-07-04 10:17 ` [PATCH] " Chris Wilson
2017-07-04 11:26   ` Tvrtko Ursulin [this message]
2017-07-04 11:29     ` Chris Wilson
2017-07-04 12:33       ` Tvrtko Ursulin
2017-07-04 12:36         ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0413339d-e777-2f6c-989b-e64d5190bac2@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).