From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/4] drm/i915: save/restore the legacy backlight control Date: Tue, 28 Aug 2012 08:16:54 +0100 Message-ID: <051c15$44688s@AZSMGA002.ch.intel.com> References: <179a19e78c99201a9ec18967c122a5a3aedbf555.1346136448.git.jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id ADD6F9E88D for ; Tue, 28 Aug 2012 00:17:14 -0700 (PDT) In-Reply-To: <179a19e78c99201a9ec18967c122a5a3aedbf555.1346136448.git.jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula , intel-gfx@lists.freedesktop.org Cc: Indan Zupancic , Takashi Iwai List-Id: intel-gfx@lists.freedesktop.org On Tue, 28 Aug 2012 09:53:36 +0300, Jani Nikula wrote: > From: Daniel Vetter > > This is a prep patch to stop drm/i915 from changing the LBPC registers > itself - but we still need to properly save/restore it on > suspend/resume. My presumption was that there were BIOSes out there that only adjusted the LBPC values, and so any device setting that flag would likely only with it through the BIOS hotkeys. I couldn't see any other rational reason for the hardware maintaining multiple interfaces... -Chris -- Chris Wilson, Intel Open Source Technology Centre