From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: fixup the plane->pipe fixup code Date: Sat, 08 Sep 2012 20:00:37 +0100 Message-ID: <051c15$48abv5@AZSMGA002.ch.intel.com> References: <275ffc$6gs6ns@fmsmga002.fm.intel.com> <1347120892-1063-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DFA09EB45 for ; Sat, 8 Sep 2012 12:00:47 -0700 (PDT) In-Reply-To: <1347120892-1063-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Sat, 8 Sep 2012 18:14:52 +0200, Daniel Vetter wrote: > We need to check whether the _other plane is on our pipe, not whether > our plane is on the other pipe. Otherwise if not both pipes/planes are > active, we won't properly clean up the mess and set up our desired > plane->pipe mapping. > > v2: Fixup the logic, I've totally fumbled it. Noticed by Chris Wilson. Frankly I'd be happier if we did both as that way we should be idiotproof, and more importantly obviously safe. -Chris -- Chris Wilson, Intel Open Source Technology Centre