From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Missed "ret" initialization on gem_context_size Date: Tue, 09 Oct 2012 19:04:09 +0100 Message-ID: <051c15$4j3k2o@AZSMGA002.ch.intel.com> References: <1349804946-4502-1-git-send-email-rodrigo.vivi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A3019F390 for ; Tue, 9 Oct 2012 11:04:17 -0700 (PDT) In-Reply-To: <1349804946-4502-1-git-send-email-rodrigo.vivi@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Rodrigo Vivi , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 9 Oct 2012 14:49:06 -0300, Rodrigo Vivi wrote: > Although default case is a bug, being conservative on the initialization helps to shut up coverity scan. > So many more issues would be resolved if you taught coverity that BUG() was noreturn. :-p -Chris -- Chris Wilson, Intel Open Source Technology Centre