From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] intel: fix fullscreen damage posting on pageflip Date: Thu, 11 Oct 2012 09:26:12 +0100 Message-ID: <051c15$4jp8te@AZSMGA002.ch.intel.com> References: <1349929829-25856-1-git-send-email-airlied@gmail.com> <6c3329$6n0p70@orsmga002.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E6FD9E843 for ; Thu, 11 Oct 2012 01:26:25 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 11 Oct 2012 18:12:18 +1000, Dave Airlie wrote: > On Thu, Oct 11, 2012 at 5:53 PM, Chris Wilson wrote: > > On Thu, 11 Oct 2012 14:30:29 +1000, Dave Airlie wrote: > >> From: Dave Airlie > >> > >> While playing with MPX and sw cursor I noticed page flips won't > >> end up misrendering some bits, so the sw cursor was replacing the > >> bits on the wrong pixmap. > >> > >> Fix the damage handling to be correct and append damage before swapping > >> the pointers and process damage after. > >> > >> This fixes misrendering with MPX cursors under a fullscreen compositor, > >> that pageflips. > > > > Wow, what magic is this? The created region is the same and > > front->drawable left unmodified by the exchange. The exchange only > > manipulates the devPrivates and has not other side effects. The only > > uncertain quantity there is the intel_glamor_exchange_buffers()... > > > > So the change is that we append the same damage to the same drawable > > earlier, yet still process that damage at the same time, with no > > apparent side-effects between the two operations. I'm just not > > understanding why this has any effect. > > Hence why I didn't do it right in the first place, I thought I > understood how damage worked :-) > > We have pre-rendering damage reporting and post-rendering damage > reporting!, so sw cursors really wants it before the fact so it can > copy the area out underneath itself, > > damage append will process the pre-damage stuff, and pending will > process post-damage hooks. Thanks for the explanation, I had forgotten that not everything was PostOp reported! commit dadffd0061e2b14db397608e3cedfe9c76e546c8 Author: Dave Airlie Date: Thu Oct 11 14:30:29 2012 +1000 intel: fix fullscreen damage posting on pageflip -Chris -- Chris Wilson, Intel Open Source Technology Centre