From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhigang Gong" Subject: Re: [PATCH 2/3] glamor: turn on glamor. Date: Fri, 11 Nov 2011 18:52:11 +0800 Message-ID: <056c01cca05f$f852b950$e8f82bf0$@linux.intel.com> References: <1321000281-5097-1-git-send-email-zhigang.gong@linux.intel.com> <1321000281-5097-2-git-send-email-zhigang.gong@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 4DF2A9E971 for ; Fri, 11 Nov 2011 02:52:14 -0800 (PST) In-Reply-To: Content-Language: zh-cn List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: 'Chris Wilson' , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org > -----Original Message----- > From: Chris Wilson [mailto:chris@chris-wilson.co.uk] > Sent: Friday, November 11, 2011 5:12 PM > To: Zhigang Gong; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 2/3] glamor: turn on glamor. > > On Fri, 11 Nov 2011 16:31:20 +0800, Zhigang Gong > wrote: > > @@ -965,6 +969,9 @@ void > intel_uxa_block_handler(intel_screen_private *intel) > > * framebuffer until significantly later. > > */ > > intel_flush_rendering(intel); > > +#ifdef GLAMOR > > + intel_glamor_block_handler(intel); > > +#endif > > } > > I suspect this is the wrong way around as we are not flushing the render > cache of glamor's rendering to the scanout until the next block handler. I don't understand here. Would you please explain more detail? Thanks. > > In general, try to keep the #ifdef out of the body of the code. In this case, > and others, make intel_glamor_block_handler() be a no-op if GLAMOR is > not enabled. Agreed, will fix it next version. > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre