Re: [PATCH 2/3] glamor: turn on glamor.

Chris Wilson
2011-11-11T09:11:46Z

On Fri, 11 Nov 2011 16:31:20 +0800, Zhigang Gong <zhigang.gong@linux.intel.com> wrote:
> @@ -965,6 +969,9 @@ void intel_uxa_block_handler(intel_screen_private *intel)
> * framebuffer until significantly later.
> */
> intel_flush_rendering(intel);
> +#ifdef GLAMOR
> + intel_glamor_block_handler(intel);
> +#endif
> }

I suspect this is the wrong way around as we are not flushing the
render cache of glamor's rendering to the scanout until the next block
handler.

In general, try to keep the #ifdef out of the body of the code. In this
case, and others, make intel_glamor_block_handler() be a no-op if GLAMOR
is not enabled.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre