From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A91EBC433EF for ; Thu, 18 Nov 2021 14:20:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F6EC6124B for ; Thu, 18 Nov 2021 14:20:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F6EC6124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6906E6E922; Thu, 18 Nov 2021 14:20:05 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id E43956E922; Thu, 18 Nov 2021 14:20:03 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10171"; a="232911668" X-IronPort-AV: E=Sophos;i="5.87,245,1631602800"; d="scan'208";a="232911668" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2021 06:20:03 -0800 X-IronPort-AV: E=Sophos;i="5.87,245,1631602800"; d="scan'208";a="473163457" Received: from davidmor-mobl1.ger.corp.intel.com (HELO [10.252.9.238]) ([10.252.9.238]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2021 06:20:01 -0800 Message-ID: <09879562-fe04-e167-bc03-5d21e4fd9744@intel.com> Date: Thu, 18 Nov 2021 14:19:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Content-Language: en-GB To: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20211118130230.154988-1-thomas.hellstrom@linux.intel.com> <20211118130230.154988-4-thomas.hellstrom@linux.intel.com> From: Matthew Auld In-Reply-To: <20211118130230.154988-4-thomas.hellstrom@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v4 3/6] drm/i915/ttm: Drop region reference counting X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 18/11/2021 13:02, Thomas Hellström wrote: > There is an interesting refcounting loop: > struct intel_memory_region has a struct ttm_resource_manager, > ttm_resource_manager->move may hold a reference to i915_request, > i915_request may hold a reference to intel_context, > intel_context may hold a reference to drm_i915_gem_object, > drm_i915_gem_object may hold a reference to intel_memory_region. > > Break this loop by dropping region reference counting. > > In addition, Have regions with a manager moving fence make sure > that all region objects are released before freeing the region. > > Signed-off-by: Thomas Hellström Reviewed-by: Matthew Auld