From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/execlists: Only mark incomplete requests as -EIO on cancelling
Date: Fri, 11 Oct 2019 13:00:00 +0100 [thread overview]
Message-ID: <0a22ccc8-dbad-b014-73e5-eaca07f93b6a@linux.intel.com> (raw)
In-Reply-To: <20191011103345.26013-1-chris@chris-wilson.co.uk>
On 11/10/2019 11:33, Chris Wilson wrote:
> Only the requests that have not completed do we want to change the
> status of to signal the -EIO when cancelling the inflight set of requests
> upon wedging.
>
> Reported-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_lrc.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
> index b00499cc7586..1f4772329021 100644
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -247,8 +247,12 @@ static void __context_pin_release(struct intel_context *ce)
>
> static void mark_eio(struct i915_request *rq)
> {
> - if (!i915_request_signaled(rq))
> - dma_fence_set_error(&rq->fence, -EIO);
> + if (i915_request_completed(rq))
> + return;
> +
> + GEM_BUG_ON(i915_request_signaled(rq));
> +
> + dma_fence_set_error(&rq->fence, -EIO);
> i915_request_mark_complete(rq);
> }
>
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-10-11 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 10:33 [PATCH] drm/i915/execlists: Only mark incomplete requests as -EIO on cancelling Chris Wilson
2019-10-11 11:12 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-10-11 12:00 ` Tvrtko Ursulin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a22ccc8-dbad-b014-73e5-eaca07f93b6a@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox