From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 13/15] drm/i915: Refactor direct GPU reset from request waiters Date: Wed, 22 Feb 2017 14:16:49 +0000 Message-ID: <0ad9adb2-ac54-79a5-caaa-62456a332705@linux.intel.com> References: <20170222114610.5819-1-chris@chris-wilson.co.uk> <20170222114610.5819-14-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 521EF896E5 for ; Wed, 22 Feb 2017 14:16:52 +0000 (UTC) In-Reply-To: <20170222114610.5819-14-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIyLzAyLzIwMTcgMTE6NDYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBDb21iaW5lIHRoZSBj b21tb24gY29kZSBmb3IgdGhlIHBhaXIgb2Ygd2FpdGVycyBpbnRvIGEgc2luZ2xlIGZ1bmN0aW9u Lgo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX3JlcXVlc3QuYyB8IDIx ICsrKysrKysrKysrKy0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygr KSwgOSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbV9yZXF1ZXN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0 LmMKPiBpbmRleCA0MjI1MGVhZjU2ZWMuLjY2ZDI5MjM4NGU2MCAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbV9yZXF1ZXN0LmMKPiBAQCAtMTAyNCw2ICsxMDI0LDE2IEBAIGJvb2wg X19pOTE1X3NwaW5fcmVxdWVzdChjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJl cSwKPiAgCXJldHVybiBmYWxzZTsKPiAgfQo+Cj4gK3N0YXRpYyBib29sIF9faTkxNV9yZXNldF9y ZXF1ZXN0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiArewo+ICsJaWYg KGxpa2VseSghaTkxNV9yZXNldF9pbl9wcm9ncmVzcygmcmVxdWVzdC0+aTkxNS0+Z3B1X2Vycm9y KSkpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsKPiArCV9fc2V0X2N1cnJlbnRfc3RhdGUoVEFTS19S VU5OSU5HKTsKPiArCWk5MTVfcmVzZXQocmVxdWVzdC0+aTkxNSk7Cj4gKwlyZXR1cm4gdHJ1ZTsK PiArfQo+ICsKPiAgLyoqCj4gICAqIGk5MTVfd2FpdF9yZXF1ZXN0IC0gd2FpdCB1bnRpbCBleGVj dXRpb24gb2YgcmVxdWVzdCBoYXMgZmluaXNoZWQKPiAgICogQHJlcTogdGhlIHJlcXVlc3QgdG8g d2FpdCB1cG9uCj4gQEAgLTEwODcsMTEgKzEwOTcsOCBAQCBsb25nIGk5MTVfd2FpdF9yZXF1ZXN0 KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLAo+ICAJCQkJYnJlYWs7Cj4KPiAgCQkJ aWYgKGZsYWdzICYgSTkxNV9XQUlUX0xPQ0tFRCAmJgo+IC0JCQkgICAgaTkxNV9yZXNldF9pbl9w cm9ncmVzcygmcmVxLT5pOTE1LT5ncHVfZXJyb3IpKSB7Cj4gLQkJCQlfX3NldF9jdXJyZW50X3N0 YXRlKFRBU0tfUlVOTklORyk7Cj4gLQkJCQlpOTE1X3Jlc2V0KHJlcS0+aTkxNSk7Cj4gKwkJCSAg ICBfX2k5MTVfcmVzZXRfcmVxdWVzdChyZXEpKQo+ICAJCQkJY29udGludWU7Cj4gLQkJCX0KPgo+ ICAJCQlpZiAoc2lnbmFsX3BlbmRpbmdfc3RhdGUoc3RhdGUsIGN1cnJlbnQpKSB7Cj4gIAkJCQl0 aW1lb3V0ID0gLUVSRVNUQVJUU1lTOwo+IEBAIC0xMTYwLDEyICsxMTY3LDggQEAgbG9uZyBpOTE1 X3dhaXRfcmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwKPiAgCQkgKiB0 byBjb21lIGFsb25nIGFuZCB1cGRhdGUgdGhlIGJyZWFkY3J1bWIgKGVpdGhlciBkaXJlY3RseQo+ ICAJCSAqIGl0c2VsZiwgb3IgaW5kaXJlY3RseSBieSByZWNvdmVyaW5nIHRoZSBHUFUpLgo+ICAJ CSAqLwo+IC0JCWlmIChmbGFncyAmIEk5MTVfV0FJVF9MT0NLRUQgJiYKPiAtCQkgICAgaTkxNV9y ZXNldF9pbl9wcm9ncmVzcygmcmVxLT5pOTE1LT5ncHVfZXJyb3IpKSB7Cj4gLQkJCV9fc2V0X2N1 cnJlbnRfc3RhdGUoVEFTS19SVU5OSU5HKTsKPiAtCQkJaTkxNV9yZXNldChyZXEtPmk5MTUpOwo+ ICsJCWlmIChmbGFncyAmIEk5MTVfV0FJVF9MT0NLRUQgJiYgX19pOTE1X3Jlc2V0X3JlcXVlc3Qo cmVxKSkKPiAgCQkJY29udGludWU7Cj4gLQkJfQo+Cj4gIAkJLyogT25seSBzcGluIGlmIHdlIGtu b3cgdGhlIEdQVSBpcyBwcm9jZXNzaW5nIHRoaXMgcmVxdWVzdCAqLwo+ICAJCWlmIChpOTE1X3Nw aW5fcmVxdWVzdChyZXEsIHN0YXRlLCAyKSkKPgoKT2theSBpbiBwcmluY2lwbGUganVzdCB1bmNs ZWFyIGZyb20gdGhlIGNvZGUgbm93IHdoYXQgaXQgZG9lcy4gSSBzdWdnZXN0IApfX2k5MTVfY2hl Y2tfYW5kX3Jlc2V0X3JlcXVlc3Qgb3IgX19pOTE1X3JlcXVlc3RfY2hlY2tfYW5kX3Jlc2V0IHNv IGl0IAppcyBvYnZpb3VzIHRoZSBzdGF0ZW1lbnQgbm90IG9ubHkgY2hlY2tzIGJ1dCBhbHNvIGRv ZXMgc3R1ZmYuCgpSZWdhcmRzLAoKVHZydGtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK