From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 4/5] drm/i915: Split the engine info table in two levels, using class + instance Date: Tue, 11 Apr 2017 12:35:01 +0100 Message-ID: <0b306171-fe48-c1e4-7cc2-7a6206ebb278@linux.intel.com> References: <1491834873-9345-1-git-send-email-oscar.mateo@intel.com> <1491834873-9345-5-git-send-email-oscar.mateo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4FF936E53D for ; Tue, 11 Apr 2017 11:35:17 +0000 (UTC) In-Reply-To: <1491834873-9345-5-git-send-email-oscar.mateo@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Oscar Mateo , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEwLzA0LzIwMTcgMTU6MzQsIE9zY2FyIE1hdGVvIHdyb3RlOgo+IFRoZXJlIGFyZSBzb21l IHByb3BlcnRpZXMgdGhhdCBsb2dpY2FsbHkgYmVsb25nIHRvIHRoZSBlbmdpbmUgY2xhc3MsIGFu ZCBzb21lCj4gdGhhdCBiZWxvbmcgdG8gdGhlIGVuZ2luZSBpbnN0YW5jZS4gTWFrZSBpdCBleHBs aWNpdC4KPgo+IHYyOiBDb21taXQgbWVzc2FnZSAoVHZydGtvKQo+Cj4gdjM6Cj4gICAtIFJlYmFz ZWQKPiAgIC0gRXhlYy91YWJpIGlkIHNob3VsZCBiZSBwZXIgaW5zdGFuY2UgKENocmlzKQo+Cj4g djQ6Cj4gICAtIFJlYmFzZWQKPiAgIC0gQXZvaWQgcmUtb3JkZXJpbmcgZmllbGRzIGZvciBzbWFs bGVyIGRpZmYgKFR2cnRrbykKPiAgIC0gQnVnIG9uIG9vYiBhY2Nlc3MgdG8gdGhlIGNsYXNzIGFy cmF5IChNaWNoYWwpCj4KPiB2NTogQnVnIG9uIHRoZSByaWdodCB0aGluZyAoTWljaGFsKQo+Cj4g djY6IFJlYmFzZWQKPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwu Y29tPgo+IENjOiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNvbT4KPiBDYzog Um9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IENjOiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8 ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogTWljaGFsIFdh amRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogT3Nj YXIgTWF0ZW8gPG9zY2FyLm1hdGVvQGludGVsLmNvbT4KPgo+IENvbmZsaWN0czoKPiAJZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKClNuaXAgdGhpcyBuZXh0IHRpbWUgdW5s ZXNzIGl0IHNuZWFrZWQgaW4gYnkgYWNjaWRlbnQuCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9lbmdpbmVfY3MuYyB8IDY1ICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0t LS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygt KQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBpbmRleCA1ZTVjZGEw Li44MGNiMGZmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2lu ZV9jcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBA QCAtMjYsNzEgKzI2LDg0IEBACj4gICNpbmNsdWRlICJpbnRlbF9yaW5nYnVmZmVyLmgiCj4gICNp bmNsdWRlICJpbnRlbF9scmMuaCIKPgo+IC1zdGF0aWMgY29uc3Qgc3RydWN0IGVuZ2luZV9pbmZv IHsKPiArc3RydWN0IGVuZ2luZV9jbGFzc19pbmZvIHsKPiAgCWNvbnN0IGNoYXIgKm5hbWU7Cj4g LQl1bnNpZ25lZCBpbnQgZXhlY19pZDsKPiArCWludCAoKmluaXRfbGVnYWN5KShzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICplbmdpbmUpOwo+ICsJaW50ICgqaW5pdF9leGVjbGlzdHMpKHN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSk7Cj4gK307Cj4gKwo+ICtzdGF0aWMgY29uc3Qgc3RydWN0 IGVuZ2luZV9jbGFzc19pbmZvIGludGVsX2VuZ2luZV9jbGFzc2VzW10gPSB7Cj4gKwlbUkVOREVS X0NMQVNTXSA9IHsKPiArCQkubmFtZSA9ICJyY3MiLAo+ICsJCS5pbml0X2V4ZWNsaXN0cyA9IGxv Z2ljYWxfcmVuZGVyX3JpbmdfaW5pdCwKPiArCQkuaW5pdF9sZWdhY3kgPSBpbnRlbF9pbml0X3Jl bmRlcl9yaW5nX2J1ZmZlciwKPiArCX0sCj4gKwlbQ09QWV9FTkdJTkVfQ0xBU1NdID0gewo+ICsJ CS5uYW1lID0gImJjcyIsCj4gKwkJLmluaXRfZXhlY2xpc3RzID0gbG9naWNhbF94Y3NfcmluZ19p bml0LAo+ICsJCS5pbml0X2xlZ2FjeSA9IGludGVsX2luaXRfYmx0X3JpbmdfYnVmZmVyLAo+ICsJ fSwKPiArCVtWSURFT19ERUNPREVfQ0xBU1NdID0gewo+ICsJCS5uYW1lID0gInZjcyIsCj4gKwkJ LmluaXRfZXhlY2xpc3RzID0gbG9naWNhbF94Y3NfcmluZ19pbml0LAo+ICsJCS5pbml0X2xlZ2Fj eSA9IGludGVsX2luaXRfYnNkX3JpbmdfYnVmZmVyLAo+ICsJfSwKPiArCVtWSURFT19FTkhBTkNF TUVOVF9DTEFTU10gPSB7Cj4gKwkJLm5hbWUgPSAidmVjcyIsCj4gKwkJLmluaXRfZXhlY2xpc3Rz ID0gbG9naWNhbF94Y3NfcmluZ19pbml0LAo+ICsJCS5pbml0X2xlZ2FjeSA9IGludGVsX2luaXRf dmVib3hfcmluZ19idWZmZXIsCj4gKwl9LAo+ICt9Owo+ICsKPiArc3RydWN0IGVuZ2luZV9pbmZv IHsKPiAgCXVuc2lnbmVkIGludCBod19pZDsKPiArCXVuc2lnbmVkIGludCBleGVjX2lkOwo+ICAJ dTggY2xhc3M7Cj4gIAl1OCBpbnN0YW5jZTsKPiAgCXUzMiBtbWlvX2Jhc2U7Cj4gIAl1bnNpZ25l ZCBpcnFfc2hpZnQ7Cj4gLQlpbnQgKCppbml0X2xlZ2FjeSkoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lKTsKPiAtCWludCAoKmluaXRfZXhlY2xpc3RzKShzdHJ1Y3QgaW50ZWxfZW5naW5l X2NzICplbmdpbmUpOwo+IC19IGludGVsX2VuZ2luZXNbXSA9IHsKPiArfTsKPiArCj4gK3N0YXRp YyBjb25zdCBzdHJ1Y3QgZW5naW5lX2luZm8gaW50ZWxfZW5naW5lc1tdID0gewo+ICAJW1JDU10g PSB7Cj4gLQkJLm5hbWUgPSAicmNzIiwKPiAgCQkuaHdfaWQgPSBSQ1NfSFcsCj4gIAkJLmV4ZWNf aWQgPSBJOTE1X0VYRUNfUkVOREVSLAo+ICAJCS5jbGFzcyA9IFJFTkRFUl9DTEFTUywKPiAgCQku aW5zdGFuY2UgPSAwLAo+ICAJCS5tbWlvX2Jhc2UgPSBSRU5ERVJfUklOR19CQVNFLAo+ICAJCS5p cnFfc2hpZnQgPSBHRU44X1JDU19JUlFfU0hJRlQsCj4gLQkJLmluaXRfZXhlY2xpc3RzID0gbG9n aWNhbF9yZW5kZXJfcmluZ19pbml0LAo+IC0JCS5pbml0X2xlZ2FjeSA9IGludGVsX2luaXRfcmVu ZGVyX3JpbmdfYnVmZmVyLAo+ICAJfSwKPiAgCVtCQ1NdID0gewo+IC0JCS5uYW1lID0gImJjcyIs Cj4gIAkJLmh3X2lkID0gQkNTX0hXLAo+ICAJCS5leGVjX2lkID0gSTkxNV9FWEVDX0JMVCwKPiAg CQkuY2xhc3MgPSBDT1BZX0VOR0lORV9DTEFTUywKPiAgCQkuaW5zdGFuY2UgPSAwLAo+ICAJCS5t bWlvX2Jhc2UgPSBCTFRfUklOR19CQVNFLAo+ICAJCS5pcnFfc2hpZnQgPSBHRU44X0JDU19JUlFf U0hJRlQsCj4gLQkJLmluaXRfZXhlY2xpc3RzID0gbG9naWNhbF94Y3NfcmluZ19pbml0LAo+IC0J CS5pbml0X2xlZ2FjeSA9IGludGVsX2luaXRfYmx0X3JpbmdfYnVmZmVyLAo+ICAJfSwKPiAgCVtW Q1NdID0gewo+IC0JCS5uYW1lID0gInZjcyIsCj4gIAkJLmh3X2lkID0gVkNTX0hXLAo+ICAJCS5l eGVjX2lkID0gSTkxNV9FWEVDX0JTRCwKPiAgCQkuY2xhc3MgPSBWSURFT19ERUNPREVfQ0xBU1Ms Cj4gIAkJLmluc3RhbmNlID0gMCwKPiAgCQkubW1pb19iYXNlID0gR0VONl9CU0RfUklOR19CQVNF LAo+ICAJCS5pcnFfc2hpZnQgPSBHRU44X1ZDUzFfSVJRX1NISUZULAo+IC0JCS5pbml0X2V4ZWNs aXN0cyA9IGxvZ2ljYWxfeGNzX3JpbmdfaW5pdCwKPiAtCQkuaW5pdF9sZWdhY3kgPSBpbnRlbF9p bml0X2JzZF9yaW5nX2J1ZmZlciwKPiAgCX0sCj4gIAlbVkNTMl0gPSB7Cj4gLQkJLm5hbWUgPSAi dmNzIiwKPiAgCQkuaHdfaWQgPSBWQ1MyX0hXLAo+ICAJCS5leGVjX2lkID0gSTkxNV9FWEVDX0JT RCwKPiAgCQkuY2xhc3MgPSBWSURFT19ERUNPREVfQ0xBU1MsCj4gIAkJLmluc3RhbmNlID0gMSwK PiAgCQkubW1pb19iYXNlID0gR0VOOF9CU0QyX1JJTkdfQkFTRSwKPiAgCQkuaXJxX3NoaWZ0ID0g R0VOOF9WQ1MyX0lSUV9TSElGVCwKPiAtCQkuaW5pdF9leGVjbGlzdHMgPSBsb2dpY2FsX3hjc19y aW5nX2luaXQsCj4gLQkJLmluaXRfbGVnYWN5ID0gaW50ZWxfaW5pdF9ic2RfcmluZ19idWZmZXIs Cj4gIAl9LAo+ICAJW1ZFQ1NdID0gewo+IC0JCS5uYW1lID0gInZlY3MiLAo+ICAJCS5od19pZCA9 IFZFQ1NfSFcsCj4gIAkJLmV4ZWNfaWQgPSBJOTE1X0VYRUNfVkVCT1gsCj4gIAkJLmNsYXNzID0g VklERU9fRU5IQU5DRU1FTlRfQ0xBU1MsCj4gIAkJLmluc3RhbmNlID0gMCwKPiAgCQkubW1pb19i YXNlID0gVkVCT1hfUklOR19CQVNFLAo+ICAJCS5pcnFfc2hpZnQgPSBHRU44X1ZFQ1NfSVJRX1NI SUZULAo+IC0JCS5pbml0X2V4ZWNsaXN0cyA9IGxvZ2ljYWxfeGNzX3JpbmdfaW5pdCwKPiAtCQku aW5pdF9sZWdhY3kgPSBpbnRlbF9pbml0X3ZlYm94X3JpbmdfYnVmZmVyLAo+ICAJfSwKPiAgfTsK Pgo+IEBAIC05OSw4ICsxMTIsMTIgQEAKPiAgCQkgICBlbnVtIGludGVsX2VuZ2luZV9pZCBpZCkK PiAgewo+ICAJY29uc3Qgc3RydWN0IGVuZ2luZV9pbmZvICppbmZvID0gJmludGVsX2VuZ2luZXNb aWRdOwo+ICsJY29uc3Qgc3RydWN0IGVuZ2luZV9jbGFzc19pbmZvICpjbGFzc19pbmZvOwo+ICAJ c3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+Cj4gKwlHRU1fQlVHX09OKGluZm8tPmNs YXNzID49IEFSUkFZX1NJWkUoaW50ZWxfZW5naW5lX2NsYXNzZXMpKTsKPiArCWNsYXNzX2luZm8g PSAmaW50ZWxfZW5naW5lX2NsYXNzZXNbaW5mby0+Y2xhc3NdOwo+ICsKPiAgCUdFTV9CVUdfT04o ZGV2X3ByaXYtPmVuZ2luZVtpZF0pOwo+ICAJZW5naW5lID0ga3phbGxvYyhzaXplb2YoKmVuZ2lu ZSksIEdGUF9LRVJORUwpOwo+ICAJaWYgKCFlbmdpbmUpCj4gQEAgLTEwOSw3ICsxMjYsNyBAQAo+ ICAJZW5naW5lLT5pZCA9IGlkOwo+ICAJZW5naW5lLT5pOTE1ID0gZGV2X3ByaXY7Cj4gIAlXQVJO X09OKHNucHJpbnRmKGVuZ2luZS0+bmFtZSwgc2l6ZW9mKGVuZ2luZS0+bmFtZSksICIlcyV1IiwK PiAtCQkJIGluZm8tPm5hbWUsIGluZm8tPmluc3RhbmNlKSA+PSBzaXplb2YoZW5naW5lLT5uYW1l KSk7Cj4gKwkJCSBjbGFzc19pbmZvLT5uYW1lLCBpbmZvLT5pbnN0YW5jZSkgPj0gc2l6ZW9mKGVu Z2luZS0+bmFtZSkpOwo+ICAJZW5naW5lLT5leGVjX2lkID0gaW5mby0+ZXhlY19pZDsKPiAgCWVu Z2luZS0+aHdfaWQgPSBlbmdpbmUtPmd1Y19pZCA9IGluZm8tPmh3X2lkOwo+ICAJZW5naW5lLT5t bWlvX2Jhc2UgPSBpbmZvLT5tbWlvX2Jhc2U7Cj4gQEAgLTE5MCwxMiArMjA3LDE0IEBAIGludCBp bnRlbF9lbmdpbmVzX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJ aW50IGVyciA9IDA7Cj4KPiAgCWZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2LCBpZCkg ewo+ICsJCWNvbnN0IHN0cnVjdCBlbmdpbmVfY2xhc3NfaW5mbyAqY2xhc3NfaW5mbyA9Cj4gKwkJ CQkJJmludGVsX2VuZ2luZV9jbGFzc2VzW2VuZ2luZS0+Y2xhc3NdOwo+ICAJCWludCAoKmluaXQp KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSk7Cj4KPiAgCQlpZiAoaTkxNS5lbmFibGVf ZXhlY2xpc3RzKQo+IC0JCQlpbml0ID0gaW50ZWxfZW5naW5lc1tpZF0uaW5pdF9leGVjbGlzdHM7 Cj4gKwkJCWluaXQgPSBjbGFzc19pbmZvLT5pbml0X2V4ZWNsaXN0czsKPiAgCQllbHNlCj4gLQkJ CWluaXQgPSBpbnRlbF9lbmdpbmVzW2lkXS5pbml0X2xlZ2FjeTsKPiArCQkJaW5pdCA9IGNsYXNz X2luZm8tPmluaXRfbGVnYWN5Owo+ICAJCWlmICghaW5pdCkgewo+ICAJCQlrZnJlZShlbmdpbmUp Owo+ICAJCQlkZXZfcHJpdi0+ZW5naW5lW2lkXSA9IE5VTEw7Cj4KClJldmlld2VkLWJ5OiBUdnJ0 a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==