public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "Kahola, Mika" <mika.kahola@intel.com>
Subject: Re: [PATCH] drm/i915/psr: Ignore device ID for Dell XPS 14 DA14260
Date: Fri, 20 Mar 2026 08:02:40 +0000	[thread overview]
Message-ID: <0b7479e3be21dbdc17eb4eb3421ea99ba9e6f34a.camel@intel.com> (raw)
In-Reply-To: <20260320075108.1395951-1-jouni.hogander@intel.com>

On Fri, 2026-03-20 at 09:51 +0200, Jouni Högander wrote:
> Dell seems to be changing device ID even within same device model.
> Due to
> this we need to ignore device ID when applying quirk for Dell XPS 14
> DA14260.
> 
> Do this by adding DEVICE_ID_ANY and assign it to Dell XPS 14 DA14260
> quirk.
> 
> Fixes: 45c77d4bf8d4 ("drm/i915/psr: Disable Panel Replay on Dell XPS
> 14 DA14260 as a quirk")
> Cc: Mika Kahola <mika.kahola@intel.com>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>

Please ignore this patch. I sent wrong version of the patch. Sorry for
inconvenience.

BR,
Jouni Högander

> ---
>  drivers/gpu/drm/i915/display/intel_quirks.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_quirks.c
> b/drivers/gpu/drm/i915/display/intel_quirks.c
> index 8f1bf8f418ec7..6fecce259fb05 100644
> --- a/drivers/gpu/drm/i915/display/intel_quirks.c
> +++ b/drivers/gpu/drm/i915/display/intel_quirks.c
> @@ -116,6 +116,8 @@ struct intel_dpcd_quirk {
>  
>  #define SINK_DEVICE_ID_ANY	SINK_DEVICE_ID(0, 0, 0, 0, 0, 0)
>  
> +#define DEVICE_ID_ANY		0
> +
>  /* For systems that don't have a meaningful PCI subdevice/subvendor
> ID */
>  struct intel_dmi_quirk {
>  	void (*hook)(struct intel_display *display);
> @@ -261,7 +263,7 @@ static const struct intel_dpcd_quirk
> intel_dpcd_quirks[] = {
>  	},
>  	/* Dell XPS 14 DA14260 */
>  	{
> -		.device = 0xb080,
> +		.device = DEVICE_ID_ANY,
>  		.subsystem_vendor = 0x1028,
>  		.subsystem_device = 0x0db9,
>  		.sink_oui = SINK_OUI(0x00, 0x22, 0xb9),
> @@ -277,7 +279,8 @@ void intel_init_quirks(struct intel_display
> *display)
>  	for (i = 0; i < ARRAY_SIZE(intel_quirks); i++) {
>  		struct intel_quirk *q = &intel_quirks[i];
>  
> -		if (d->device == q->device &&
> +		if ((d->device == q->device ||
> +		     q->device == DEVICE_ID_ANY) &&
>  		    (d->subsystem_vendor == q->subsystem_vendor ||
>  		     q->subsystem_vendor == PCI_ANY_ID) &&
>  		    (d->subsystem_device == q->subsystem_device ||


      reply	other threads:[~2026-03-20  8:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20  7:51 [PATCH] drm/i915/psr: Ignore device ID for Dell XPS 14 DA14260 Jouni Högander
2026-03-20  8:02 ` Hogander, Jouni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b7479e3be21dbdc17eb4eb3421ea99ba9e6f34a.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mika.kahola@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox