From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v3] drm/i915/execlists: Reset CSB write pointer after reset Date: Thu, 28 Jun 2018 13:15:07 +0100 Message-ID: <0bb7cdcd-3122-6a42-a90c-b7d98eb25d70@linux.intel.com> References: <20180627210712.25428-6-chris@chris-wilson.co.uk> <20180628115908.31933-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5F9966E1EC for ; Thu, 28 Jun 2018 12:15:10 +0000 (UTC) In-Reply-To: <20180628115908.31933-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI4LzA2LzIwMTggMTI6NTksIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiBIVyByZXNldCwg dGhlIEhXIGNsZWFycyB0aGUgd3JpdGUgcG9pbnRlciAodG8gMCkuIEJ1dCBzaW5jZSBpdCBhbHNv Cj4gd3JpdGVzIGl0cyBmaXJzdCBDU0IgZW50cnkgdG8gc2xvdCAwLCB3ZSBuZWVkIHRvIHJlc2V0 IHRoZSB3cml0ZSBwb2ludGVyCj4gYmFjayB0byB0aGUgZWxlbWVudCBiZWZvcmUgKHNvIHRoZSBm aXJzdCBlbnRyeSB3ZSByZWFkIGlzIDApLgo+IAo+IFRoaXMgaXMgcmVxdWlyZWQgZm9yIHRoZSBu ZXh0IHBhdGNoLCB3aGVyZSB3ZSB0cnVzdCB0aGUgQ1NCIGNvbXBsZXRlbHkhCj4gCj4gdjI6IFVz ZSBfTUFTS0VEX0ZJRUxECj4gdjM6IFN0b3JlIHRoZSByZXNldCB2YWx1ZSwgc28gdGhhdCB3ZSBk aWZmZXJlbnRpYXRlIGJldHdlZW4gbW1pby9od3NwCj4gdHJhbnNwYXJlbnRseSBhbmQgd2l0aG91 dCBwcmV0ZW5zZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVs LmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAgICB8 IDIzICsrKysrKysrKysrKysrKysrKysrKy0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9yaW5nYnVmZmVyLmggfCAgOSArKysrKysrKysKPiAgIDIgZmlsZXMgY2hhbmdlZCwgMzAgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ IGluZGV4IDg1MzFhNWI2ZjZmZi4uNDliZjUwNDgwNDNjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfbHJjLmMKPiBAQCAtODg0LDYgKzg4NCwyMSBAQCBzdGF0aWMgdm9pZCByZXNldF9pcnEoc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCWNsZWFyX2JpdChFTkdJTkVfSVJRX0VY RUNMSVNULCAmZW5naW5lLT5pcnFfcG9zdGVkKTsKPiAgIH0KPiAgIAo+ICtzdGF0aWMgdm9pZCBy ZXNldF9jc2JfcG9pbnRlcnMoc3RydWN0IGludGVsX2VuZ2luZV9leGVjbGlzdHMgKmV4ZWNsaXN0 cykKPiArewo+ICsJLyoKPiArCSAqIEFmdGVyIGEgcmVzZXQsIHRoZSBIVyBzdGFydHMgd3JpdGlu ZyBpbnRvIENTQiBlbnRyeSBbMF0uIFdlCj4gKwkgKiB0aGVyZWZvcmUgaGF2ZSB0byBzZXQgb3Vy IEhFQUQgcG9pbnRlciBiYWNrIG9uZSBlbnRyeSBzbyB0aGF0Cj4gKwkgKiB0aGUgKmZpcnN0KiBl bnRyeSB3ZSBjaGVjayBpcyBlbnRyeSAwLiBUbyBjb21wbGljYXRlIHRoaXMgZnVydGhlciwKPiAr CSAqIGFzIHdlIGRvbid0IHdhaXQgZm9yIHRoZSBmaXJzdCBpbnRlcnJ1cHQgYWZ0ZXIgcmVzZXQs IHdlIGhhdmUgdG8KPiArCSAqIGZha2UgdGhlIEhXIHdyaXRlIHRvIHBvaW50IGJhY2sgdG8gdGhl IGxhc3QgZW50cnkgc28gdGhhdCBvdXIKPiArCSAqIGlubGluZSBjb21wYXJpc29uIG9mIG91ciBj YWNoZWQgaGVhZCBwb3NpdGlvbiBhZ2FpbnN0IHRoZSBsYXN0IEhXCj4gKwkgKiB3cml0ZSB3b3Jr cyBldmVuIGJlZm9yZSB0aGUgZmlyc3QgaW50ZXJydXB0Lgo+ICsJICovCj4gKwlleGVjbGlzdHMt PmNzYl9oZWFkID0gZXhlY2xpc3RzLT5jc2Jfd3JpdGVfcmVzZXQgJiAweGZmOwoKSWRlYSBmb3Ig YXZvaWRpbmcgdGhlICYgMHhmZiBhbmQgYXBwbHlpbmcgdGhlIHRyaWNrIHRocm91Z2hvdXQgLSBt YWtlIApjc2JfaGVhZCB1OC4gOikKCj4gKwlXUklURV9PTkNFKCpleGVjbGlzdHMtPmNzYl93cml0 ZSwgZXhlY2xpc3RzLT5jc2Jfd3JpdGVfcmVzZXQpOwo+ICt9Cj4gKwo+ICAgc3RhdGljIHZvaWQg ZXhlY2xpc3RzX2NhbmNlbF9yZXF1ZXN0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUp Cj4gICB7Cj4gICAJc3RydWN0IGludGVsX2VuZ2luZV9leGVjbGlzdHMgKiBjb25zdCBleGVjbGlz dHMgPSAmZW5naW5lLT5leGVjbGlzdHM7Cj4gQEAgLTE5NzAsNyArMTk4NSw3IEBAIHN0YXRpYyB2 b2lkIGV4ZWNsaXN0c19yZXNldChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gICAJ X191bndpbmRfaW5jb21wbGV0ZV9yZXF1ZXN0cyhlbmdpbmUpOwo+ICAgCj4gICAJLyogRm9sbG93 aW5nIHRoZSByZXNldCwgd2UgbmVlZCB0byByZWxvYWQgdGhlIENTQiByZWFkL3dyaXRlIHBvaW50 ZXJzICovCj4gLQllbmdpbmUtPmV4ZWNsaXN0cy5jc2JfaGVhZCA9IEdFTjhfQ1NCX0VOVFJJRVMg LSAxOwo+ICsJcmVzZXRfY3NiX3BvaW50ZXJzKCZlbmdpbmUtPmV4ZWNsaXN0cyk7Cj4gICAKPiAg IAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2ssIGZsYWdzKTsK PiAgIAo+IEBAIC0yNDY5LDcgKzI0ODQsNiBAQCBzdGF0aWMgaW50IGxvZ2ljYWxfcmluZ19pbml0 KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAkJCXVwcGVyXzMyX2JpdHMoY2Ut PmxyY19kZXNjKTsKPiAgIAl9Cj4gICAKPiAtCWV4ZWNsaXN0cy0+Y3NiX2hlYWQgPSBHRU44X0NT Ql9FTlRSSUVTIC0gMTsKPiAgIAlleGVjbGlzdHMtPmNzYl9yZWFkID0KPiAgIAkJaTkxNS0+cmVn cyArIGk5MTVfbW1pb19yZWdfb2Zmc2V0KFJJTkdfQ09OVEVYVF9TVEFUVVNfUFRSKGVuZ2luZSkp Owo+ICAgCWlmIChjc2JfZm9yY2VfbW1pbyhpOTE1KSkgewo+IEBAIC0yNDc3LDEzICsyNDkxLDE4 IEBAIHN0YXRpYyBpbnQgbG9naWNhbF9yaW5nX2luaXQoc3RydWN0IGludGVsX2VuZ2luZV9jcyAq ZW5naW5lKQo+ICAgCQkJKGk5MTUtPnJlZ3MgKyBpOTE1X21taW9fcmVnX29mZnNldChSSU5HX0NP TlRFWFRfU1RBVFVTX0JVRl9MTyhlbmdpbmUsIDApKSk7Cj4gICAKPiAgIAkJZXhlY2xpc3RzLT5j c2Jfd3JpdGUgPSAodTMyIF9fZm9yY2UgKilleGVjbGlzdHMtPmNzYl9yZWFkOwo+ICsJCWV4ZWNs aXN0cy0+Y3NiX3dyaXRlX3Jlc2V0ID0KPiArCQkJX01BU0tFRF9GSUVMRChHRU44X0NTQl9XUklU RV9QVFJfTUFTSywKPiArCQkJCSAgICAgIEdFTjhfQ1NCX0VOVFJJRVMgLSAxKTsKPiAgIAl9IGVs c2Ugewo+ICAgCQlleGVjbGlzdHMtPmNzYl9zdGF0dXMgPQo+ICAgCQkJJmVuZ2luZS0+c3RhdHVz X3BhZ2UucGFnZV9hZGRyW0k5MTVfSFdTX0NTQl9CVUYwX0lOREVYXTsKPiAgIAo+ICAgCQlleGVj bGlzdHMtPmNzYl93cml0ZSA9Cj4gICAJCQkmZW5naW5lLT5zdGF0dXNfcGFnZS5wYWdlX2FkZHJb aW50ZWxfaHdzX2NzYl93cml0ZV9pbmRleChpOTE1KV07Cj4gKwkJZXhlY2xpc3RzLT5jc2Jfd3Jp dGVfcmVzZXQgPSBHRU44X0NTQl9FTlRSSUVTIC0gMTsKPiAgIAl9Cj4gKwlyZXNldF9jc2JfcG9p bnRlcnMoZXhlY2xpc3RzKTsKPiAgIAo+ICAgCXJldHVybiAwOwo+ICAgCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+IGluZGV4IDk3MGRiYjNjOTgxMi4uNmVjN2MwMTli NWQ5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIu aAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+IEBAIC0z MDQsNiArMzA0LDE1IEBAIHN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzIHsKPiAgIAkgKi8K PiAgIAl1bnNpZ25lZCBpbnQgY3NiX2hlYWQ7Cj4gICAKPiArCS8qKgo+ICsJICogQGNzYl93cml0 ZV9yZXNldDogcmVzZXQgdmFsdWUgZm9yIENTQiB3cml0ZSBwb2ludGVyCj4gKwkgKgo+ICsJICog QXMgdGhlIENTQiB3cml0ZSBwb2ludGVyIG1heWJlIGVpdGhlciBpbiBIV1NQIG9yIGFzIGEgZmll bGQKPiArCSAqIGluc2lkZSBhbiBtbWlvIHJlZ2lzdGVyLCB3ZSB3YW50IHRvIHJlcHJvZ3JhbSBp dCBzbGlnaHRseQo+ICsJICogZGlmZmVyZW50bHkgdG8gYXZvaWQgbGF0ZXIgY29uZnVzaW9uLgo+ ICsJICovCj4gKwl1MzIgY3NiX3dyaXRlX3Jlc2V0Owo+ICsKPiAgIAkvKioKPiAgIAkgKiBAY3Ni X3JlYWQ6IGNvbnRyb2wgcmVnaXN0ZXIgZm9yIENvbnRleHQgU3dpdGNoIGJ1ZmZlcgo+ICAgCSAq Cj4gCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNv bT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==