From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Fix the graphics frequency clamping at init and when IPS is active. Date: Tue, 02 Nov 2010 09:37:35 +0000 Message-ID: <0d30dc$k253ut@orsmga001.jf.intel.com> References: <1288645921-5402-1-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B6EF9E8B3 for ; Tue, 2 Nov 2010 02:37:42 -0700 (PDT) In-Reply-To: <1288645921-5402-1-git-send-email-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 1 Nov 2010 14:12:01 -0700, Eric Anholt wrote: > From: Jesse Barnes > > Part of the issue here was that Eric slipped in a debug hack for > testing the i915 IPS code before the intel_ips.c driver had landed. > This caused the driver to always use the full range of frequencies, > which is only legal when IPS tells us we have the headroom. Once that > hack was removed, there was confusion about the driver's frequency > clamping variables: max_delay is the driver's current limit on the > highest frequency the IPS driver wants us to use, while dev_priv->fmax > is the hardware-reported limit that the IPS driver can increase up to. Dropped the promotion to DRM_ERROR and applied to -fixes. Since your changelog says that what we have right now is programming invalid values into the IPS, I've marked it for stable. -Chris -- Chris Wilson, Intel Open Source Technology Centre