From: Chris Wilson <chris@chris-wilson.co.uk>
To: Cyril Brulebois <kibi@debian.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/5] xvmc: Silence gcc, add parentheses around arithmetic.
Date: Mon, 31 Jan 2011 09:50:29 +0000 [thread overview]
Message-ID: <0d30dc$ktp5h7@orsmga001.jf.intel.com> (raw)
In-Reply-To: <1296451359-28449-3-git-send-email-kibi@debian.org>
[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]
On Mon, 31 Jan 2011 06:22:37 +0100, Cyril Brulebois <kibi@debian.org> wrote:
> Get rid of those accordingly with CFLAGS="-Wall -Werror":
> | CC i915_xvmc.lo
> | cc1: warnings being treated as errors
> | i915_xvmc.c: In function ‘i915_mc_one_time_state_emit’:
> | i915_xvmc.c:369: error: suggest parentheses around arithmetic in operand of ‘|’
> | i915_xvmc.c:374: error: suggest parentheses around arithmetic in operand of ‘|’
> | i915_xvmc.c:379: error: suggest parentheses around arithmetic in operand of ‘|’
> | i915_xvmc.c: In function ‘i915_mc_load_indirect_render_emit’:
> | i915_xvmc.c:708: error: suggest parentheses around arithmetic in operand of ‘|’
> | i915_xvmc.c:713: error: suggest parentheses around arithmetic in operand of ‘|’
Fix the macro instead.
diff --git a/src/xvmc/intel_batchbuffer.h b/src/xvmc/intel_batchbuffer.h
index 6fa1c05..888abeb 100644
--- a/src/xvmc/intel_batchbuffer.h
+++ b/src/xvmc/intel_batchbuffer.h
@@ -24,7 +24,7 @@ extern int VERBOSE;
#define OUT_RELOC(bo,read_domains,write_domains,delta) \
do { \
- *(unsigned int *)batch_ptr = delta + bo->offset; \
+ *(unsigned int *)batch_ptr = (delta) + bo->offset; \
intel_batch_emit_reloc(bo, read_domains, write_domains, delta, batch_pt
batch_ptr += 4; \
} while (0)
--
Chris Wilson, Intel Open Source Technology Centre
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-01-31 9:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 5:22 [PATCH 1/5] xvmc: Get rid of unused variables Cyril Brulebois
2011-01-31 5:22 ` [PATCH 2/5] xvmc: Silence gcc, add parentheses around assignment Cyril Brulebois
2011-01-31 5:22 ` [PATCH 3/5] xvmc: Silence gcc, add parentheses around arithmetic Cyril Brulebois
2011-01-31 9:50 ` Chris Wilson [this message]
2011-01-31 9:55 ` Julien Cristau
2011-01-31 5:22 ` [PATCH 4/5] xvmc: Silence gcc, adding a cast to work around signedness issues Cyril Brulebois
2011-01-31 5:22 ` [PATCH 5/5] xvmc: Stop using uninitialized variable Cyril Brulebois
2011-01-31 10:05 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0d30dc$ktp5h7@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kibi@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox