From: Chris Wilson <chris@chris-wilson.co.uk>
To: Eric Anholt <eric@anholt.net>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 13/15] drm/i915: Implement GTT variants of pread
Date: Wed, 23 Mar 2011 17:30:22 +0000 [thread overview]
Message-ID: <0d30dc$li0dde@orsmga001.jf.intel.com> (raw)
In-Reply-To: <87zkolwy1p.fsf@pollan.anholt.net>
On Wed, 23 Mar 2011 10:23:46 -0700, Eric Anholt <eric@anholt.net> wrote:
> On Tue, 22 Mar 2011 13:51:58 +0000, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Again, needs more justification. For example, I would expect us not to
> bother with the GTT on SNB pread/pwrite, and just read the backing pages
> (they're in our cache, no need to clflush or anything) like we already
> have code to do. And one note below.
Right, so snooped pages goes through the shmem paths, nothing changes. Not
everything is as nice as SNB and keeping the pages in the GTT is a benefit
for everything else.
[snip]
> So, previously if I pread a tiled object, I got the tiled data. Now
> you're giving me maybe the tiled data, maybe the data untiled by reading
> through a fence.
No, it clears the fence before reading to maintain the existing API that
isn't that useful in current practice.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-03-23 17:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 13:51 next tidbits - use LLC on SNB Chris Wilson
2011-03-22 13:51 ` [PATCH 01/15] drm/i915: Enable use of GPU semaphores to sync page-flips " Chris Wilson
2011-03-22 20:44 ` Keith Packard
2011-03-22 13:51 ` [PATCH 02/15] drm/i915: Accurately track flushed domains Chris Wilson
2011-03-22 21:07 ` Keith Packard
2011-03-22 13:51 ` [PATCH 03/15] drm/i915: Track last read/write seqno independently Chris Wilson
2011-03-23 17:16 ` Eric Anholt
2011-03-22 13:51 ` [PATCH 04/15] drm/i915: Rename agp_type to cache_level Chris Wilson
2011-03-22 13:51 ` [PATCH 05/15] drm/i915: Mark the cursor and the overlay as being part of the display planes Chris Wilson
2011-03-22 13:51 ` [PATCH 06/15] drm/i915: Add an interface to dynamically change the cache level Chris Wilson
2011-03-22 13:51 ` [PATCH 07/15] drm/i915: Do not clflush snooped objects Chris Wilson
2011-03-22 13:51 ` [PATCH 08/15] drm/i915: Use the uncached domain for the display planes Chris Wilson
2011-03-22 13:51 ` [PATCH 09/15] drm/i915: Refactor pwrite/pread to use single copy of get_user_pages Chris Wilson
2011-03-22 13:51 ` [PATCH 10/15] drm/i915: Use kmap_atomic for shmem pread Chris Wilson
2011-03-22 13:51 ` [PATCH 11/15] drm/i915: Use the CPU domain for snooped pwrites Chris Wilson
2011-03-22 13:51 ` [PATCH 12/15] drm/i915: s/addr & ~PAGE_MASK/offset_in_page(addr)/ Chris Wilson
2011-03-22 13:51 ` [PATCH 13/15] drm/i915: Implement GTT variants of pread Chris Wilson
2011-03-23 17:23 ` Eric Anholt
2011-03-23 17:30 ` Chris Wilson [this message]
2011-03-24 17:44 ` Keith Packard
2011-03-24 19:47 ` Chris Wilson
2011-03-22 13:51 ` [PATCH 14/15] drm/i915: Cleanup flush|invalidate domain tracking for set_to_gpu Chris Wilson
2011-03-22 13:52 ` [PATCH 15/15] drm/i915: Use the LLC mode on gen6 for everything but display Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0d30dc$li0dde@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox