From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 16/21] drm/i915: Move idle barrier cleanup into engine-pm Date: Fri, 20 Sep 2019 17:18:08 +0100 Message-ID: <0e7ace14-650b-aa16-8a7b-5afd37fdb690@linux.intel.com> References: <20190902040303.14195-1-chris@chris-wilson.co.uk> <20190902040303.14195-16-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 57A026E08C for ; Fri, 20 Sep 2019 16:18:11 +0000 (UTC) In-Reply-To: <20190902040303.14195-16-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAyLzA5LzIwMTkgMDU6MDIsIENocmlzIFdpbHNvbiB3cm90ZToKPiBOb3cgdGhhdCB3ZSBu b3cgbG9uZ2VyIG5lZWQgdG8gZ3VhcmFudGVlIHRoYXQgdGhlIGFjdGl2ZSBjYWxsYmFjayBpcwo+ IHVuZGVyIHRoZSBzdHJ1Y3RfbXV0ZXgsIHdlIGNhbiBsaWZ0IGl0IG91dCBvZiB0aGUgaTkxNV9n ZW1fcGFyaygpIGFuZAo+IGludG8gdGhlIGVuZ2luZSBwYXJraW5nIGl0c2VsZi4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0K PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9wbS5jICAgIHwgMTkgLS0tLS0t LS0tLS0tLS0tLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfZW5naW5lX3Bt LmMgfCAxNSArKysrKysrKysrKysrKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfYWN0 aXZlLmMgICAgICAgIHwgIDEgKwo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCsp LCAxOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv Z2VtL2k5MTVfZ2VtX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fcG0u Ywo+IGluZGV4IDkyNTU4ZmE0NzEwOC4uNmU0Y2MxNzdjYzdhIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9wbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvZ2VtL2k5MTVfZ2VtX3BtLmMKPiBAQCAtMTEsMjkgKzExLDEwIEBACj4gICAjaW5jbHVk ZSAiaTkxNV9kcnYuaCIKPiAgICNpbmNsdWRlICJpOTE1X2dsb2JhbHMuaCIKPiAgIAo+IC1zdGF0 aWMgdm9pZCBjYWxsX2lkbGVfYmFycmllcnMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5l KQo+IC17Cj4gLQlzdHJ1Y3QgbGxpc3Rfbm9kZSAqbm9kZSwgKm5leHQ7Cj4gLQo+IC0JbGxpc3Rf Zm9yX2VhY2hfc2FmZShub2RlLCBuZXh0LCBsbGlzdF9kZWxfYWxsKCZlbmdpbmUtPmJhcnJpZXJf dGFza3MpKSB7Cj4gLQkJc3RydWN0IGRtYV9mZW5jZV9jYiAqY2IgPQo+IC0JCQljb250YWluZXJf b2YoKHN0cnVjdCBsaXN0X2hlYWQgKilub2RlLAo+IC0JCQkJICAgICB0eXBlb2YoKmNiKSwgbm9k ZSk7Cj4gLQo+IC0JCWNiLT5mdW5jKE5VTEwsIGNiKTsKPiAtCX0KPiAtfQo+IC0KPiAgIHN0YXRp YyB2b2lkIGk5MTVfZ2VtX3Bhcmsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gICB7 Cj4gLQlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmU7Cj4gLQllbnVtIGludGVsX2VuZ2lu ZV9pZCBpZDsKPiAtCj4gICAJbG9ja2RlcF9hc3NlcnRfaGVsZCgmaTkxNS0+ZHJtLnN0cnVjdF9t dXRleCk7Cj4gICAKPiAtCWZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGk5MTUsIGlkKQo+IC0JCWNh bGxfaWRsZV9iYXJyaWVycyhlbmdpbmUpOyAvKiBjbGVhbnVwIGFmdGVyIHdlZGdpbmcgKi8KPiAt Cj4gICAJaTkxNV92bWFfcGFya2VkKGk5MTUpOwo+ICAgCj4gICAJaTkxNV9nbG9iYWxzX3Bhcmso KTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfZW5naW5lX3Bt LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9lbmdpbmVfcG0uYwo+IGluZGV4IDY1 YjVjYTc0YjM5NC4uNDcyYjIyNTlmNjI5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2d0L2ludGVsX2VuZ2luZV9wbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Qv aW50ZWxfZW5naW5lX3BtLmMKPiBAQCAtMTIzLDYgKzEyMywxOSBAQCBzdGF0aWMgYm9vbCBzd2l0 Y2hfdG9fa2VybmVsX2NvbnRleHQoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAg CXJldHVybiByZXN1bHQ7Cj4gICB9Cj4gICAKPiArc3RhdGljIHZvaWQgY2FsbF9pZGxlX2JhcnJp ZXJzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiArewo+ICsJc3RydWN0IGxsaXN0 X25vZGUgKm5vZGUsICpuZXh0Owo+ICsKPiArCWxsaXN0X2Zvcl9lYWNoX3NhZmUobm9kZSwgbmV4 dCwgbGxpc3RfZGVsX2FsbCgmZW5naW5lLT5iYXJyaWVyX3Rhc2tzKSkgewo+ICsJCXN0cnVjdCBk bWFfZmVuY2VfY2IgKmNiID0KPiArCQkJY29udGFpbmVyX29mKChzdHJ1Y3QgbGlzdF9oZWFkICop bm9kZSwKPiArCQkJCSAgICAgdHlwZW9mKCpjYiksIG5vZGUpOwo+ICsKPiArCQljYi0+ZnVuYyhO VUxMLCBjYik7Cj4gKwl9Cj4gK30KPiArCj4gICBzdGF0aWMgaW50IF9fZW5naW5lX3Bhcmsoc3Ry dWN0IGludGVsX3dha2VyZWYgKndmKQo+ICAgewo+ICAgCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSA9Cj4gQEAgLTE0Miw2ICsxNTUsOCBAQCBzdGF0aWMgaW50IF9fZW5naW5lX3Bhcmso c3RydWN0IGludGVsX3dha2VyZWYgKndmKQo+ICAgCj4gICAJR0VNX1RSQUNFKCIlc1xuIiwgZW5n aW5lLT5uYW1lKTsKPiAgIAo+ICsJY2FsbF9pZGxlX2JhcnJpZXJzKGVuZ2luZSk7IC8qIGNsZWFu dXAgYWZ0ZXIgd2VkZ2luZyAqLwo+ICsKPiAgIAlpbnRlbF9lbmdpbmVfZGlzYXJtX2JyZWFkY3J1 bWJzKGVuZ2luZSk7Cj4gICAJaW50ZWxfZW5naW5lX3Bvb2xfcGFyaygmZW5naW5lLT5wb29sKTsK PiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2FjdGl2ZS5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9hY3RpdmUuYwo+IGluZGV4IDJlMmFiODE3NjYyMC4u ZGNmNWJjMWQ4N2U2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfYWN0 aXZlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2FjdGl2ZS5jCj4gQEAgLTY3 OSw2ICs2NzksNyBAQCB2b2lkIGk5MTVfYWN0aXZlX2FjcXVpcmVfYmFycmllcihzdHJ1Y3QgaTkx NV9hY3RpdmUgKnJlZikKPiAgIAkJcmJfbGlua19ub2RlKCZub2RlLT5ub2RlLCBwYXJlbnQsIHAp Owo+ICAgCQlyYl9pbnNlcnRfY29sb3IoJm5vZGUtPm5vZGUsICZyZWYtPnRyZWUpOwo+ICAgCj4g KwkJR0VNX0JVR19PTighaW50ZWxfZW5naW5lX3BtX2lzX2F3YWtlKGVuZ2luZSkpOwo+ICAgCQls bGlzdF9hZGQoYmFycmllcl90b19sbChub2RlKSwgJmVuZ2luZS0+YmFycmllcl90YXNrcyk7Cj4g ICAJCWludGVsX2VuZ2luZV9wbV9wdXQoZW5naW5lKTsKPiAgIAl9Cj4gCgpJZiB0aGUgcmVzdCBw bGF5cyBvdXQgdGhpcyBpcyBzaW1wbGUuIDopCgpSZXZpZXdlZC1ieTogVHZydGtvIFVyc3VsaW4g PHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4