From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 544A2C2BA80 for ; Mon, 6 Apr 2020 15:29:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29A0320719 for ; Mon, 6 Apr 2020 15:29:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="aTi0ATN9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29A0320719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D3B26E425; Mon, 6 Apr 2020 15:29:16 +0000 (UTC) Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8EC6A6E0E9 for ; Sat, 4 Apr 2020 10:05:59 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id i20so9504893ljn.6 for ; Sat, 04 Apr 2020 03:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=f5WeYVcExZ58viobGo5xENBYY/7iA5WtiHNaBP74Ohk=; b=aTi0ATN9MaY24407laRnBef6LfGPpOgdRBwSwCQz2c3RW4Gj/WkUSmsjFupt1+Si1I /jw0cOt3bzoZ1L8XI8Cd7xl4uND//yB9GJHWzUv8WZWdrs2vMEb5P/6AngfEuXPZiSGf XPfLEX+uHTRcYFmBj3aEbcKNRHtdDgUwBBnViuTIu3RWq8uVF0MXaSq7dRYUFOEfUxag Me75vpJfK3iUGksokG2xHslbFjKJVBBYOFEjoY7PYPAXlsjqaldQ3YKyfSNa7FMzpHkn t+K46duTvK6NW20LFcqGjElqmIe9KQb5vJm4zg6VH9x14j7uPUY0uawotq+psxvUvGUB UXxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=f5WeYVcExZ58viobGo5xENBYY/7iA5WtiHNaBP74Ohk=; b=Xrcy+hZKplgWiAJNAR0cvPZYHImOJD+Zl2rKfJq4BZgvH9rYhB8StGIrGb7kSK1QKk kYSaflTGDc7jQeDKXklt5SLpmpDty3IG0ftffzeeGYZMAqHHZ+26BBzfgGqJcgyu+NfZ WhwElOsxyBOlBtVA/vvYI9JzY+ECnV0bWuXpb4smkBNaW9zYZlINY0J4yzlfRfzj9j2z AqMUAIcISfikVnhh3Jy0zoxiaSOMyOQQbEH8GhGje1kQJAEOs62BIVexrLEvoQ7odWgb HV4MlqO3cUyEtsMt2ne7UrPwk7CvfBnsw2WoPatI3wNyj03txmdrxMXjAhQnGEmt5FL1 ujWw== X-Gm-Message-State: AGi0Pub6VGqkI21D8WHpM8j5Uy9Z5nE7Kh7dROsqMRXc27emL+VH3Sck kwA9M4gzSMEkbUxjwOEtS4N/Wg== X-Google-Smtp-Source: APiQypJgK3TXAPv85OfJ7vCTcz4u4tUzYYbvpr+INBxhiypWT+murLDDhRYYaeJT38bk35encw/Ldg== X-Received: by 2002:a2e:818e:: with SMTP id e14mr7232769ljg.225.1585994757852; Sat, 04 Apr 2020 03:05:57 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:6f0:5f98:6c2c:3527:3946:ae? ([2a00:1fa0:6f0:5f98:6c2c:3527:3946:ae]) by smtp.gmail.com with ESMTPSA id p21sm6378055ljg.5.2020.04.04.03.05.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Apr 2020 03:05:57 -0700 (PDT) To: Christoph Hellwig , Linus Torvalds , Andrew Morton References: <20200404094101.672954-1-hch@lst.de> <20200404094101.672954-3-hch@lst.de> From: Sergei Shtylyov Message-ID: <0fb3cce8-fa3d-5c97-1eba-0f359797eea2@cogentembedded.com> Date: Sat, 4 Apr 2020 13:05:52 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200404094101.672954-3-hch@lst.de> Content-Language: en-US X-Mailman-Approved-At: Mon, 06 Apr 2020 15:29:14 +0000 Subject: Re: [Intel-gfx] [PATCH 2/6] i915/gvt/kvm: a NULL ->mm does not mean a thread is a kthread X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Felipe Balbi , amd-gfx@lists.freedesktop.org, "Michael S. Tsirkin" , Felix Kuehling , linux-usb@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Al Viro , intel-gfx@lists.freedesktop.org, Alex Deucher , intel-gvt-dev@lists.freedesktop.org, Jason Wang Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hello! On 04.04.2020 12:40, Christoph Hellwig wrote: > Use the proper API instead. > > Fixes: f440c8a572d7 ("drm/i915/gvt/kvmgt: read/write GPA via KVM API") > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c > index 074c4efb58eb..5848400620b4 100644 > --- a/drivers/gpu/drm/i915/gvt/kvmgt.c > +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c > @@ -2037,7 +2037,7 @@ static int kvmgt_rw_gpa(unsigned long handle, unsigned long gpa, > struct kvmgt_guest_info *info; > struct kvm *kvm; > int idx, ret; > - bool kthread = current->mm == NULL; > + bool kthread = (current->flags & PF_KTHREAD); Don't need the parens. [...] MBR, Sergei _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx