From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 03/19] drm/i915/gt: Close race between engine_park and intel_gt_retire_requests Date: Wed, 20 Nov 2019 11:39:00 +0000 Message-ID: <0ff23ea0-aab9-66be-78bd-a09481044572@linux.intel.com> References: <20191118230254.2615942-1-chris@chris-wilson.co.uk> <20191118230254.2615942-4-chris@chris-wilson.co.uk> <157417451261.10169.17308970866103066621@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 074826E264 for ; Wed, 20 Nov 2019 11:39:03 +0000 (UTC) In-Reply-To: <157417451261.10169.17308970866103066621@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Matthew Auld List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE5LzExLzIwMTkgMTQ6NDEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTExLTE5IDE0OjE1OjQ5KQo+Pgo+PiBPbiAxOC8xMS8yMDE5IDIzOjAy LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBUaGUgZ2VuZXJhbCBjb25jZXB0IHdhcyB0aGF0IGlu dGVsX3RpbWVsaW5lLmFjdGl2ZV9jb3VudCB3YXMgbG9ja2VkIGJ5Cj4+PiB0aGUgaW50ZWxfdGlt ZWxpbmUubXV0ZXguIFRoZSBleGNlcHRpb24gd2FzIGZvciBwb3dlciBtYW5hZ2VtZW50LCB3aGVy ZQo+Pj4gdGhlIGVuZ2luZS0+a2VybmVsX2NvbnRleHQtPnRpbWVsaW5lIGNvdWxkIGJlIG1hbmlw dWxhdGVkIHVuZGVyIHRoZQo+Pj4gZ2xvYmFsIHdha2VyZWYubXV0ZXguCj4+Pgo+Pj4gVGhpcyB3 YXMgcXVpdGUgc29saWQsIGFzIHdlIGFsd2F5cyBtYW5pcHVsYXRlZCB0aGUgdGltZWxpbmUgb25s eSB3aGlsZQo+Pj4gd2UgaGVsZCBhbiBlbmdpbmUgd2FrZXJlZi4KPj4+Cj4+PiBBbmQgdGhlbiB3 ZSBzdGFydGVkIHJldGlyaW5nIHJlcXVlc3RzIG91dHNpZGUgb2Ygc3RydWN0X211dGV4LCBvbmx5 Cj4+PiB1c2luZyB0aGUgdGltZWxpbmVzLmFjdGl2ZV9saXN0IGFuZCB0aGUgdGltZWxpbmUtPm11 dGV4LiBUaGVyZSB3ZQo+Pj4gc3RhcnRlZCBtYW5pcHVsYXRpbmcgaW50ZWxfdGltZWxpbmUuYWN0 aXZlX2NvdW50IG91dHNpZGUgb2YgYW4gZW5naW5lCj4+PiB3YWtlcmVmLCBhbmQgc28gaW50cm9k dWNlZCBhIHJhY2UgYmV0d2VlbiBfX2VuZ2luZV9wYXJrKCkgYW5kCj4+PiBpbnRlbF9ndF9yZXRp cmVfcmVxdWVzdHMoKSwgYSByYWNlIHRoYXQgY291bGQgcmVzdWx0IGluIHRoZQo+Pj4gZW5naW5l LT5rZXJuZWxfY29udGV4dCBub3QgYmVpbmcgYWRkZWQgdG8gdGhlIGFjdGl2ZSB0aW1lbGluZXMg YW5kIHNvCj4+PiBsb3NpbmcgcmVxdWVzdHMsIHdoaWNoIGNhdXNlZCB1cyB0byBrZWVwIHRoZSBz eXN0ZW0gcGVybWFuZW50bHkgcG93ZXJlZAo+Pj4gdXAgW2FuZCB1bmxvYWRhYmxlXS4KPj4+Cj4+ PiBUaGUgcmFjZSB3b3VsZCBiZSBlYXN5IHRvIGNsb3NlIGlmIHdlIGNvdWxkIHRha2UgdGhlIGVu Z2luZSB3YWtlcmVmIGZvcgo+Pj4gdGhlIHRpbWVsaW5lIGJlZm9yZSB3ZSByZXRpcmUgLS0gZXhj ZXB0IHRpbWVsaW5lcyBhcmUgbm90IGJvdW5kIHRvIGFueQo+Pj4gZW5naW5lIGFuZCBzbyB3ZSB3 b3VsZCBuZWVkIHRvIGtlZXAgYWxsIGFjdGl2ZSBlbmdpbmVzIGF3YWtlLiBUaGUKPj4+IGFsdGVy bmF0aXZlIGlzIHRvIGd1YXJkIGludGVsX3RpbWVsaW5lX2VudGVyL2ludGVsX3RpbWVsaW5lX2V4 aXQgZm9yIHVzZQo+Pj4gb3V0c2lkZSBvZiB0aGUgdGltZWxpbmUtPm11dGV4Lgo+Pj4KPj4+IEZp eGVzOiBlNWRhZGZmNGIwOTMgKCJkcm0vaTkxNTogUHJvdGVjdCByZXF1ZXN0IHJldGlyZW1lbnQg d2l0aCB0aW1lbGluZS0+bXV0ZXgiKQo+Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxj aHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+PiBDYzogTWF0dGhldyBBdWxkIDxtYXR0aGV3LmF1 bGRAaW50ZWwuY29tPgo+Pj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRl bC5jb20+Cj4+PiAtLS0KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2d0X3Jl cXVlc3RzLmMgICB8ICA4ICsrLS0tCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRl bF90aW1lbGluZS5jICAgICAgfCAzNCArKysrKysrKysrKysrKystLS0tCj4+PiAgICAuLi4vZ3B1 L2RybS9pOTE1L2d0L2ludGVsX3RpbWVsaW5lX3R5cGVzLmggICAgfCAgMiArLQo+Pj4gICAgMyBm aWxlcyBjaGFuZ2VkLCAzMiBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPj4+Cj4+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfZ3RfcmVxdWVzdHMuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2d0X3JlcXVlc3RzLmMKPj4+IGluZGV4IGE3 OWU2ZWZiMzFhMi4uNzU1OWQ2MzczZjQ5IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvZ3QvaW50ZWxfZ3RfcmVxdWVzdHMuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvZ3QvaW50ZWxfZ3RfcmVxdWVzdHMuYwo+Pj4gQEAgLTQ5LDggKzQ5LDggQEAgbG9uZyBpbnRl bF9ndF9yZXRpcmVfcmVxdWVzdHNfdGltZW91dChzdHJ1Y3QgaW50ZWxfZ3QgKmd0LCBsb25nIHRp bWVvdXQpCj4+PiAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+Pj4gICAgCj4+PiAg ICAgICAgICAgICAgICBpbnRlbF90aW1lbGluZV9nZXQodGwpOwo+Pj4gLSAgICAgICAgICAgICBH RU1fQlVHX09OKCF0bC0+YWN0aXZlX2NvdW50KTsKPj4+IC0gICAgICAgICAgICAgdGwtPmFjdGl2 ZV9jb3VudCsrOyAvKiBwaW4gdGhlIGxpc3QgZWxlbWVudCAqLwo+Pj4gKyAgICAgICAgICAgICBH RU1fQlVHX09OKCFhdG9taWNfcmVhZCgmdGwtPmFjdGl2ZV9jb3VudCkpOwo+Pj4gKyAgICAgICAg ICAgICBhdG9taWNfaW5jKCZ0bC0+YWN0aXZlX2NvdW50KTsgLyogcGluIHRoZSBsaXN0IGVsZW1l bnQgKi8KPj4+ICAgICAgICAgICAgICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJnRpbWVsaW5l cy0+bG9jaywgZmxhZ3MpOwo+Pj4gICAgCj4+PiAgICAgICAgICAgICAgICBpZiAodGltZW91dCA+ IDApIHsKPj4+IEBAIC03MSwxNCArNzEsMTQgQEAgbG9uZyBpbnRlbF9ndF9yZXRpcmVfcmVxdWVz dHNfdGltZW91dChzdHJ1Y3QgaW50ZWxfZ3QgKmd0LCBsb25nIHRpbWVvdXQpCj4+PiAgICAKPj4+ ICAgICAgICAgICAgICAgIC8qIFJlc3VtZSBpdGVyYXRpb24gYWZ0ZXIgZHJvcHBpbmcgbG9jayAq Lwo+Pj4gICAgICAgICAgICAgICAgbGlzdF9zYWZlX3Jlc2V0X25leHQodGwsIHRuLCBsaW5rKTsK Pj4+IC0gICAgICAgICAgICAgaWYgKCEtLXRsLT5hY3RpdmVfY291bnQpCj4+PiArICAgICAgICAg ICAgIGlmIChhdG9taWNfZGVjX2FuZF90ZXN0KCZ0bC0+YWN0aXZlX2NvdW50KSkKPj4+ICAgICAg ICAgICAgICAgICAgICAgICAgbGlzdF9kZWwoJnRsLT5saW5rKTsKPj4+ICAgIAo+Pj4gICAgICAg ICAgICAgICAgbXV0ZXhfdW5sb2NrKCZ0bC0+bXV0ZXgpOwo+Pj4gICAgCj4+PiAgICAgICAgICAg ICAgICAvKiBEZWZlciB0aGUgZmluYWwgcmVsZWFzZSB0byBhZnRlciB0aGUgc3BpbmxvY2sgKi8K Pj4+ICAgICAgICAgICAgICAgIGlmIChyZWZjb3VudF9kZWNfYW5kX3Rlc3QoJnRsLT5rcmVmLnJl ZmNvdW50KSkgewo+Pj4gLSAgICAgICAgICAgICAgICAgICAgIEdFTV9CVUdfT04odGwtPmFjdGl2 ZV9jb3VudCk7Cj4+PiArICAgICAgICAgICAgICAgICAgICAgR0VNX0JVR19PTihhdG9taWNfcmVh ZCgmdGwtPmFjdGl2ZV9jb3VudCkpOwo+Pj4gICAgICAgICAgICAgICAgICAgICAgICBsaXN0X2Fk ZCgmdGwtPmxpbmssICZmcmVlKTsKPj4+ICAgICAgICAgICAgICAgIH0KPj4+ICAgICAgICB9Cj4+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfdGltZWxpbmUuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3RpbWVsaW5lLmMKPj4+IGluZGV4IDE2YTll ODhkOTNkZS4uNGY5MTRmMGQ1ZWFiIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvZ3QvaW50ZWxfdGltZWxpbmUuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Qv aW50ZWxfdGltZWxpbmUuYwo+Pj4gQEAgLTMzNCwxNSArMzM0LDMzIEBAIHZvaWQgaW50ZWxfdGlt ZWxpbmVfZW50ZXIoc3RydWN0IGludGVsX3RpbWVsaW5lICp0bCkKPj4+ICAgICAgICBzdHJ1Y3Qg aW50ZWxfZ3RfdGltZWxpbmVzICp0aW1lbGluZXMgPSAmdGwtPmd0LT50aW1lbGluZXM7Cj4+PiAg ICAgICAgdW5zaWduZWQgbG9uZyBmbGFnczsKPj4+ICAgIAo+Pj4gKyAgICAgLyoKPj4+ICsgICAg ICAqIFByZXRlbmQgd2UgYXJlIHNlcmlhbGlzZWQgYnkgdGhlIHRpbWVsaW5lLT5tdXRleC4KPj4+ ICsgICAgICAqCj4+PiArICAgICAgKiBXaGlsZSBnZW5lcmFsbHkgdHJ1ZSwgdGhlcmUgYXJlIGEg ZmV3IGV4Y2VwdGlvbnMgdG8gdGhlIHJ1bGUKPj4+ICsgICAgICAqIGZvciB0aGUgZW5naW5lLT5r ZXJuZWxfY29udGV4dCBiZWluZyB1c2VkIHRvIG1hbmFnZSBwb3dlcgo+Pj4gKyAgICAgICogdHJh bnNpdGlvbnMuIEFzIHRoZSBlbmdpbmVfcGFyayBtYXkgYmUgY2FsbGVkIGZyb20gdW5kZXIgYW55 Cj4+PiArICAgICAgKiB0aW1lbGluZSwgaXQgdXNlcyB0aGUgcG93ZXIgbXV0ZXggYXMgYSBnbG9i YWwgc2VyaWFsaXNhdGlvbgo+Pj4gKyAgICAgICogbG9jayB0byBwcmV2ZW50IGFueSBvdGhlciBy ZXF1ZXN0IGVudGVyaW5nIGl0cyB0aW1lbGluZS4KPj4+ICsgICAgICAqCj4+PiArICAgICAgKiBU aGUgcnVsZSBpcyBnZW5lcmFsbHkgdGwtPm11dGV4LCBvdGhlcndpc2UgZW5naW5lLT53YWtlcmVm Lm11dGV4Lgo+Pj4gKyAgICAgICoKPj4+ICsgICAgICAqIEhvd2V2ZXIsIGludGVsX2d0X3JldGly ZV9yZXF1ZXN0KCkgZG9lcyBub3Qga25vdyB3aGljaCBlbmdpbmUKPj4+ICsgICAgICAqIGl0IGlz IHJldGlyaW5nIGFsb25nIGFuZCBzbyBjYW5ub3QgcGFydGFrZSBpbiB0aGUgZW5naW5lLXBtCj4+ PiArICAgICAgKiBiYXJyaWVyLCBhbmQgdGhlcmUgd2UgdXNlIHRoZSB0bC0+YWN0aXZlX2NvdW50 IGFzIGEgbWVhbnMgdG8KPj4+ICsgICAgICAqIHBpbiB0aGUgdGltZWxpbmUgaW4gdGhlIGFjdGl2 ZV9saXN0IHdoaWxlIHRoZSBsb2NrcyBhcmUgZHJvcHBlZC4KPj4+ICsgICAgICAqIEVyZ28sIGFz IHRoYXQgaXMgb3V0c2lkZSBvZiB0aGUgZW5naW5lLXBtIGJhcnJpZXIsIHdlIG5lZWQgdG8KPj4+ ICsgICAgICAqIHVzZSBhdG9taWMgdG8gbWFuaXB1bGF0ZSB0bC0+YWN0aXZlX2NvdW50Lgo+Pj4g KyAgICAgICovCj4+PiAgICAgICAgbG9ja2RlcF9hc3NlcnRfaGVsZCgmdGwtPm11dGV4KTsKPj4+ IC0KPj4+ICAgICAgICBHRU1fQlVHX09OKCFhdG9taWNfcmVhZCgmdGwtPnBpbl9jb3VudCkpOwo+ Pj4gLSAgICAgaWYgKHRsLT5hY3RpdmVfY291bnQrKykKPj4+ICsKPj4+ICsgICAgIGlmIChhdG9t aWNfYWRkX3VubGVzcygmdGwtPmFjdGl2ZV9jb3VudCwgMSwgMCkpCj4+PiAgICAgICAgICAgICAg ICByZXR1cm47Cj4+PiAtICAgICBHRU1fQlVHX09OKCF0bC0+YWN0aXZlX2NvdW50KTsgLyogb3Zl cmZsb3c/ICovCj4+PiAgICAKPj4+ICAgICAgICBzcGluX2xvY2tfaXJxc2F2ZSgmdGltZWxpbmVz LT5sb2NrLCBmbGFncyk7Cj4+PiAtICAgICBsaXN0X2FkZCgmdGwtPmxpbmssICZ0aW1lbGluZXMt PmFjdGl2ZV9saXN0KTsKPj4+ICsgICAgIGlmICghYXRvbWljX2ZldGNoX2luYygmdGwtPmFjdGl2 ZV9jb3VudCkpCj4+PiArICAgICAgICAgICAgIGxpc3RfYWRkKCZ0bC0+bGluaywgJnRpbWVsaW5l cy0+YWN0aXZlX2xpc3QpOwo+Pgo+PiBTbyByZXRpcmVtZW50IHJhY2VkIHdpdGggdGhpcyBhbmQg aGFzIGVsZXZhdGVkIHRoZSBhY3RpdmVfY291bnQ/IEJ1dAo+PiByZXRpcmVtZW50IGRvZXMgbm90 IGFkZCB0aGUgdGltZWxpbmUgdG8gdGhlIGxpc3QsIHNvIHdlIGV4aXQgaGVyZQo+PiB3aXRob3V0 IGl0IG9uIHRoZSBhY3RpdmVfbGlzdC4KPiAKPiBSZXRpcmVtZW50IG9ubHkgc2VlcyBhbiBlbGVt ZW50IG9uIHRoZSBhY3RpdmVfbGlzdC4gV2hhdCB3ZSBvYnNlcnZlZCBpbgo+IHByYWN0aWNlIHdh cyB0aGUgaW5jL2RlYyBvbiB0bC0+YWN0aXZlX2NvdW50IHJhY2luZywgY2F1c2luZwo+IGluZGV0 ZXJtaW5hdGUgcmVzdWx0cywgd2l0aCB0aGUgcmVzdWx0IHRoYXQgd2UgcmVtb3ZlZCB0aGUgZWxl bWVudCBmcm9tCj4gdGhlIGFjdGl2ZV9saXN0IHdoaWxlIGl0IGhhZCBhIHJhaXNlZCB0bC0+YWN0 aXZlX2NvdW50IChkdWUgdG8gdGhlCj4gaW5mbGlnaHQgcG9zdGluZyBmcm9tIHRoZSBvdGhlciBD UFUpLgo+IAo+IFRodXMgd2Uga2VwdCByZXF1ZXN0cyBpbmZsaWdodCBhbmQgdGhlIGVuZ2luZSBh d2FrZSB3aXRoIG5vIHdheSB0byBjbGVhcgo+IHRoZW0uIFRoaXMgbW9zdCBvYnZpb3VzIHRyaWdn ZXJlZCBHRU1fQlVHX09OKGd0LT5hd2FrZSkgZHVyaW5nIHN1c3BlbmQsCj4gYW5kIGlzIGFsc28g cmVzcG9uc2libGUgZm9yIHRoZSB0aW1lb3V0cyBvbiBnZW1fcXVpZXNjZW50X2dwdSgpIG9yCj4g aWd0X2Ryb3BfY2FjaGVzX3NldChEUk9QX0lETEUpLgoKSSB1bmRlcnN0YW5kIChJIHRoaW5rKSB0 aGUgcmFjZSB3aGVyZSByZXRpcmVtZW50IHJhY2VzIHdpdGggcGFya2luZy4gQnV0IAp0aGlzIHNp ZGUgb2YgdGhpbmdzIChpbnRlbF90aW1lbGluZV9lbnRlcikgZG9lcyBub3Qgc2VlbSB0byBiZSBp bnZvbHZlZCAKaW4gdGhhdC4gaW50ZWxfdGltZWxpbmVfZW50ZXIgaXMgdGhlIG9ubHkgcGxhY2Ug d2hpY2ggcHV0cyB0aGUgdGltZWxpbmUgCm9udG8gdGhlIGFjdGl2ZV9saXN0LiBIb3cgY2FuIHR3 byBvZiB0aGVtIHJhY2U/CgpBbmQgYWxzbywgd2hhdCByZW1haW5zIHRvIGJlIHB1cnBvc2Ugb2Yg dGltZWxpbmVzLT5sb2NrPwoKUmVnYXJkcywKClR2cnRrbwoKCgoKCgoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A404FC432C3 for ; Wed, 20 Nov 2019 11:39:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81BF721906 for ; Wed, 20 Nov 2019 11:39:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81BF721906 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 293E26E264; Wed, 20 Nov 2019 11:39:05 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 074826E264 for ; Wed, 20 Nov 2019 11:39:03 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 03:39:03 -0800 X-IronPort-AV: E=Sophos;i="5.69,221,1571727600"; d="scan'208";a="200689321" Received: from unknown (HELO [10.252.30.240]) ([10.252.30.240]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/AES256-SHA; 20 Nov 2019 03:39:02 -0800 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20191118230254.2615942-1-chris@chris-wilson.co.uk> <20191118230254.2615942-4-chris@chris-wilson.co.uk> <157417451261.10169.17308970866103066621@skylake-alporthouse-com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <0ff23ea0-aab9-66be-78bd-a09481044572@linux.intel.com> Date: Wed, 20 Nov 2019 11:39:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <157417451261.10169.17308970866103066621@skylake-alporthouse-com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 03/19] drm/i915/gt: Close race between engine_park and intel_gt_retire_requests X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthew Auld Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191120113900.t2FyQM-YQEeDSZ9chzMhadlOAEhGgbyUsvWtNDjxxwk@z> Ck9uIDE5LzExLzIwMTkgMTQ6NDEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTExLTE5IDE0OjE1OjQ5KQo+Pgo+PiBPbiAxOC8xMS8yMDE5IDIzOjAy LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBUaGUgZ2VuZXJhbCBjb25jZXB0IHdhcyB0aGF0IGlu dGVsX3RpbWVsaW5lLmFjdGl2ZV9jb3VudCB3YXMgbG9ja2VkIGJ5Cj4+PiB0aGUgaW50ZWxfdGlt ZWxpbmUubXV0ZXguIFRoZSBleGNlcHRpb24gd2FzIGZvciBwb3dlciBtYW5hZ2VtZW50LCB3aGVy ZQo+Pj4gdGhlIGVuZ2luZS0+a2VybmVsX2NvbnRleHQtPnRpbWVsaW5lIGNvdWxkIGJlIG1hbmlw dWxhdGVkIHVuZGVyIHRoZQo+Pj4gZ2xvYmFsIHdha2VyZWYubXV0ZXguCj4+Pgo+Pj4gVGhpcyB3 YXMgcXVpdGUgc29saWQsIGFzIHdlIGFsd2F5cyBtYW5pcHVsYXRlZCB0aGUgdGltZWxpbmUgb25s eSB3aGlsZQo+Pj4gd2UgaGVsZCBhbiBlbmdpbmUgd2FrZXJlZi4KPj4+Cj4+PiBBbmQgdGhlbiB3 ZSBzdGFydGVkIHJldGlyaW5nIHJlcXVlc3RzIG91dHNpZGUgb2Ygc3RydWN0X211dGV4LCBvbmx5 Cj4+PiB1c2luZyB0aGUgdGltZWxpbmVzLmFjdGl2ZV9saXN0IGFuZCB0aGUgdGltZWxpbmUtPm11 dGV4LiBUaGVyZSB3ZQo+Pj4gc3RhcnRlZCBtYW5pcHVsYXRpbmcgaW50ZWxfdGltZWxpbmUuYWN0 aXZlX2NvdW50IG91dHNpZGUgb2YgYW4gZW5naW5lCj4+PiB3YWtlcmVmLCBhbmQgc28gaW50cm9k dWNlZCBhIHJhY2UgYmV0d2VlbiBfX2VuZ2luZV9wYXJrKCkgYW5kCj4+PiBpbnRlbF9ndF9yZXRp cmVfcmVxdWVzdHMoKSwgYSByYWNlIHRoYXQgY291bGQgcmVzdWx0IGluIHRoZQo+Pj4gZW5naW5l LT5rZXJuZWxfY29udGV4dCBub3QgYmVpbmcgYWRkZWQgdG8gdGhlIGFjdGl2ZSB0aW1lbGluZXMg YW5kIHNvCj4+PiBsb3NpbmcgcmVxdWVzdHMsIHdoaWNoIGNhdXNlZCB1cyB0byBrZWVwIHRoZSBz eXN0ZW0gcGVybWFuZW50bHkgcG93ZXJlZAo+Pj4gdXAgW2FuZCB1bmxvYWRhYmxlXS4KPj4+Cj4+ PiBUaGUgcmFjZSB3b3VsZCBiZSBlYXN5IHRvIGNsb3NlIGlmIHdlIGNvdWxkIHRha2UgdGhlIGVu Z2luZSB3YWtlcmVmIGZvcgo+Pj4gdGhlIHRpbWVsaW5lIGJlZm9yZSB3ZSByZXRpcmUgLS0gZXhj ZXB0IHRpbWVsaW5lcyBhcmUgbm90IGJvdW5kIHRvIGFueQo+Pj4gZW5naW5lIGFuZCBzbyB3ZSB3 b3VsZCBuZWVkIHRvIGtlZXAgYWxsIGFjdGl2ZSBlbmdpbmVzIGF3YWtlLiBUaGUKPj4+IGFsdGVy bmF0aXZlIGlzIHRvIGd1YXJkIGludGVsX3RpbWVsaW5lX2VudGVyL2ludGVsX3RpbWVsaW5lX2V4 aXQgZm9yIHVzZQo+Pj4gb3V0c2lkZSBvZiB0aGUgdGltZWxpbmUtPm11dGV4Lgo+Pj4KPj4+IEZp eGVzOiBlNWRhZGZmNGIwOTMgKCJkcm0vaTkxNTogUHJvdGVjdCByZXF1ZXN0IHJldGlyZW1lbnQg d2l0aCB0aW1lbGluZS0+bXV0ZXgiKQo+Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxj aHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+PiBDYzogTWF0dGhldyBBdWxkIDxtYXR0aGV3LmF1 bGRAaW50ZWwuY29tPgo+Pj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRl bC5jb20+Cj4+PiAtLS0KPj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2d0X3Jl cXVlc3RzLmMgICB8ICA4ICsrLS0tCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRl bF90aW1lbGluZS5jICAgICAgfCAzNCArKysrKysrKysrKysrKystLS0tCj4+PiAgICAuLi4vZ3B1 L2RybS9pOTE1L2d0L2ludGVsX3RpbWVsaW5lX3R5cGVzLmggICAgfCAgMiArLQo+Pj4gICAgMyBm aWxlcyBjaGFuZ2VkLCAzMiBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPj4+Cj4+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfZ3RfcmVxdWVzdHMuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2d0X3JlcXVlc3RzLmMKPj4+IGluZGV4IGE3 OWU2ZWZiMzFhMi4uNzU1OWQ2MzczZjQ5IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvZ3QvaW50ZWxfZ3RfcmVxdWVzdHMuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvZ3QvaW50ZWxfZ3RfcmVxdWVzdHMuYwo+Pj4gQEAgLTQ5LDggKzQ5LDggQEAgbG9uZyBpbnRl bF9ndF9yZXRpcmVfcmVxdWVzdHNfdGltZW91dChzdHJ1Y3QgaW50ZWxfZ3QgKmd0LCBsb25nIHRp bWVvdXQpCj4+PiAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+Pj4gICAgCj4+PiAg ICAgICAgICAgICAgICBpbnRlbF90aW1lbGluZV9nZXQodGwpOwo+Pj4gLSAgICAgICAgICAgICBH RU1fQlVHX09OKCF0bC0+YWN0aXZlX2NvdW50KTsKPj4+IC0gICAgICAgICAgICAgdGwtPmFjdGl2 ZV9jb3VudCsrOyAvKiBwaW4gdGhlIGxpc3QgZWxlbWVudCAqLwo+Pj4gKyAgICAgICAgICAgICBH RU1fQlVHX09OKCFhdG9taWNfcmVhZCgmdGwtPmFjdGl2ZV9jb3VudCkpOwo+Pj4gKyAgICAgICAg ICAgICBhdG9taWNfaW5jKCZ0bC0+YWN0aXZlX2NvdW50KTsgLyogcGluIHRoZSBsaXN0IGVsZW1l bnQgKi8KPj4+ICAgICAgICAgICAgICAgIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJnRpbWVsaW5l cy0+bG9jaywgZmxhZ3MpOwo+Pj4gICAgCj4+PiAgICAgICAgICAgICAgICBpZiAodGltZW91dCA+ IDApIHsKPj4+IEBAIC03MSwxNCArNzEsMTQgQEAgbG9uZyBpbnRlbF9ndF9yZXRpcmVfcmVxdWVz dHNfdGltZW91dChzdHJ1Y3QgaW50ZWxfZ3QgKmd0LCBsb25nIHRpbWVvdXQpCj4+PiAgICAKPj4+ ICAgICAgICAgICAgICAgIC8qIFJlc3VtZSBpdGVyYXRpb24gYWZ0ZXIgZHJvcHBpbmcgbG9jayAq Lwo+Pj4gICAgICAgICAgICAgICAgbGlzdF9zYWZlX3Jlc2V0X25leHQodGwsIHRuLCBsaW5rKTsK Pj4+IC0gICAgICAgICAgICAgaWYgKCEtLXRsLT5hY3RpdmVfY291bnQpCj4+PiArICAgICAgICAg ICAgIGlmIChhdG9taWNfZGVjX2FuZF90ZXN0KCZ0bC0+YWN0aXZlX2NvdW50KSkKPj4+ICAgICAg ICAgICAgICAgICAgICAgICAgbGlzdF9kZWwoJnRsLT5saW5rKTsKPj4+ICAgIAo+Pj4gICAgICAg ICAgICAgICAgbXV0ZXhfdW5sb2NrKCZ0bC0+bXV0ZXgpOwo+Pj4gICAgCj4+PiAgICAgICAgICAg ICAgICAvKiBEZWZlciB0aGUgZmluYWwgcmVsZWFzZSB0byBhZnRlciB0aGUgc3BpbmxvY2sgKi8K Pj4+ICAgICAgICAgICAgICAgIGlmIChyZWZjb3VudF9kZWNfYW5kX3Rlc3QoJnRsLT5rcmVmLnJl ZmNvdW50KSkgewo+Pj4gLSAgICAgICAgICAgICAgICAgICAgIEdFTV9CVUdfT04odGwtPmFjdGl2 ZV9jb3VudCk7Cj4+PiArICAgICAgICAgICAgICAgICAgICAgR0VNX0JVR19PTihhdG9taWNfcmVh ZCgmdGwtPmFjdGl2ZV9jb3VudCkpOwo+Pj4gICAgICAgICAgICAgICAgICAgICAgICBsaXN0X2Fk ZCgmdGwtPmxpbmssICZmcmVlKTsKPj4+ICAgICAgICAgICAgICAgIH0KPj4+ICAgICAgICB9Cj4+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfdGltZWxpbmUuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3RpbWVsaW5lLmMKPj4+IGluZGV4IDE2YTll ODhkOTNkZS4uNGY5MTRmMGQ1ZWFiIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvZ3QvaW50ZWxfdGltZWxpbmUuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Qv aW50ZWxfdGltZWxpbmUuYwo+Pj4gQEAgLTMzNCwxNSArMzM0LDMzIEBAIHZvaWQgaW50ZWxfdGlt ZWxpbmVfZW50ZXIoc3RydWN0IGludGVsX3RpbWVsaW5lICp0bCkKPj4+ICAgICAgICBzdHJ1Y3Qg aW50ZWxfZ3RfdGltZWxpbmVzICp0aW1lbGluZXMgPSAmdGwtPmd0LT50aW1lbGluZXM7Cj4+PiAg ICAgICAgdW5zaWduZWQgbG9uZyBmbGFnczsKPj4+ICAgIAo+Pj4gKyAgICAgLyoKPj4+ICsgICAg ICAqIFByZXRlbmQgd2UgYXJlIHNlcmlhbGlzZWQgYnkgdGhlIHRpbWVsaW5lLT5tdXRleC4KPj4+ ICsgICAgICAqCj4+PiArICAgICAgKiBXaGlsZSBnZW5lcmFsbHkgdHJ1ZSwgdGhlcmUgYXJlIGEg ZmV3IGV4Y2VwdGlvbnMgdG8gdGhlIHJ1bGUKPj4+ICsgICAgICAqIGZvciB0aGUgZW5naW5lLT5r ZXJuZWxfY29udGV4dCBiZWluZyB1c2VkIHRvIG1hbmFnZSBwb3dlcgo+Pj4gKyAgICAgICogdHJh bnNpdGlvbnMuIEFzIHRoZSBlbmdpbmVfcGFyayBtYXkgYmUgY2FsbGVkIGZyb20gdW5kZXIgYW55 Cj4+PiArICAgICAgKiB0aW1lbGluZSwgaXQgdXNlcyB0aGUgcG93ZXIgbXV0ZXggYXMgYSBnbG9i YWwgc2VyaWFsaXNhdGlvbgo+Pj4gKyAgICAgICogbG9jayB0byBwcmV2ZW50IGFueSBvdGhlciBy ZXF1ZXN0IGVudGVyaW5nIGl0cyB0aW1lbGluZS4KPj4+ICsgICAgICAqCj4+PiArICAgICAgKiBU aGUgcnVsZSBpcyBnZW5lcmFsbHkgdGwtPm11dGV4LCBvdGhlcndpc2UgZW5naW5lLT53YWtlcmVm Lm11dGV4Lgo+Pj4gKyAgICAgICoKPj4+ICsgICAgICAqIEhvd2V2ZXIsIGludGVsX2d0X3JldGly ZV9yZXF1ZXN0KCkgZG9lcyBub3Qga25vdyB3aGljaCBlbmdpbmUKPj4+ICsgICAgICAqIGl0IGlz IHJldGlyaW5nIGFsb25nIGFuZCBzbyBjYW5ub3QgcGFydGFrZSBpbiB0aGUgZW5naW5lLXBtCj4+ PiArICAgICAgKiBiYXJyaWVyLCBhbmQgdGhlcmUgd2UgdXNlIHRoZSB0bC0+YWN0aXZlX2NvdW50 IGFzIGEgbWVhbnMgdG8KPj4+ICsgICAgICAqIHBpbiB0aGUgdGltZWxpbmUgaW4gdGhlIGFjdGl2 ZV9saXN0IHdoaWxlIHRoZSBsb2NrcyBhcmUgZHJvcHBlZC4KPj4+ICsgICAgICAqIEVyZ28sIGFz IHRoYXQgaXMgb3V0c2lkZSBvZiB0aGUgZW5naW5lLXBtIGJhcnJpZXIsIHdlIG5lZWQgdG8KPj4+ ICsgICAgICAqIHVzZSBhdG9taWMgdG8gbWFuaXB1bGF0ZSB0bC0+YWN0aXZlX2NvdW50Lgo+Pj4g KyAgICAgICovCj4+PiAgICAgICAgbG9ja2RlcF9hc3NlcnRfaGVsZCgmdGwtPm11dGV4KTsKPj4+ IC0KPj4+ICAgICAgICBHRU1fQlVHX09OKCFhdG9taWNfcmVhZCgmdGwtPnBpbl9jb3VudCkpOwo+ Pj4gLSAgICAgaWYgKHRsLT5hY3RpdmVfY291bnQrKykKPj4+ICsKPj4+ICsgICAgIGlmIChhdG9t aWNfYWRkX3VubGVzcygmdGwtPmFjdGl2ZV9jb3VudCwgMSwgMCkpCj4+PiAgICAgICAgICAgICAg ICByZXR1cm47Cj4+PiAtICAgICBHRU1fQlVHX09OKCF0bC0+YWN0aXZlX2NvdW50KTsgLyogb3Zl cmZsb3c/ICovCj4+PiAgICAKPj4+ICAgICAgICBzcGluX2xvY2tfaXJxc2F2ZSgmdGltZWxpbmVz LT5sb2NrLCBmbGFncyk7Cj4+PiAtICAgICBsaXN0X2FkZCgmdGwtPmxpbmssICZ0aW1lbGluZXMt PmFjdGl2ZV9saXN0KTsKPj4+ICsgICAgIGlmICghYXRvbWljX2ZldGNoX2luYygmdGwtPmFjdGl2 ZV9jb3VudCkpCj4+PiArICAgICAgICAgICAgIGxpc3RfYWRkKCZ0bC0+bGluaywgJnRpbWVsaW5l cy0+YWN0aXZlX2xpc3QpOwo+Pgo+PiBTbyByZXRpcmVtZW50IHJhY2VkIHdpdGggdGhpcyBhbmQg aGFzIGVsZXZhdGVkIHRoZSBhY3RpdmVfY291bnQ/IEJ1dAo+PiByZXRpcmVtZW50IGRvZXMgbm90 IGFkZCB0aGUgdGltZWxpbmUgdG8gdGhlIGxpc3QsIHNvIHdlIGV4aXQgaGVyZQo+PiB3aXRob3V0 IGl0IG9uIHRoZSBhY3RpdmVfbGlzdC4KPiAKPiBSZXRpcmVtZW50IG9ubHkgc2VlcyBhbiBlbGVt ZW50IG9uIHRoZSBhY3RpdmVfbGlzdC4gV2hhdCB3ZSBvYnNlcnZlZCBpbgo+IHByYWN0aWNlIHdh cyB0aGUgaW5jL2RlYyBvbiB0bC0+YWN0aXZlX2NvdW50IHJhY2luZywgY2F1c2luZwo+IGluZGV0 ZXJtaW5hdGUgcmVzdWx0cywgd2l0aCB0aGUgcmVzdWx0IHRoYXQgd2UgcmVtb3ZlZCB0aGUgZWxl bWVudCBmcm9tCj4gdGhlIGFjdGl2ZV9saXN0IHdoaWxlIGl0IGhhZCBhIHJhaXNlZCB0bC0+YWN0 aXZlX2NvdW50IChkdWUgdG8gdGhlCj4gaW5mbGlnaHQgcG9zdGluZyBmcm9tIHRoZSBvdGhlciBD UFUpLgo+IAo+IFRodXMgd2Uga2VwdCByZXF1ZXN0cyBpbmZsaWdodCBhbmQgdGhlIGVuZ2luZSBh d2FrZSB3aXRoIG5vIHdheSB0byBjbGVhcgo+IHRoZW0uIFRoaXMgbW9zdCBvYnZpb3VzIHRyaWdn ZXJlZCBHRU1fQlVHX09OKGd0LT5hd2FrZSkgZHVyaW5nIHN1c3BlbmQsCj4gYW5kIGlzIGFsc28g cmVzcG9uc2libGUgZm9yIHRoZSB0aW1lb3V0cyBvbiBnZW1fcXVpZXNjZW50X2dwdSgpIG9yCj4g aWd0X2Ryb3BfY2FjaGVzX3NldChEUk9QX0lETEUpLgoKSSB1bmRlcnN0YW5kIChJIHRoaW5rKSB0 aGUgcmFjZSB3aGVyZSByZXRpcmVtZW50IHJhY2VzIHdpdGggcGFya2luZy4gQnV0IAp0aGlzIHNp ZGUgb2YgdGhpbmdzIChpbnRlbF90aW1lbGluZV9lbnRlcikgZG9lcyBub3Qgc2VlbSB0byBiZSBp bnZvbHZlZCAKaW4gdGhhdC4gaW50ZWxfdGltZWxpbmVfZW50ZXIgaXMgdGhlIG9ubHkgcGxhY2Ug d2hpY2ggcHV0cyB0aGUgdGltZWxpbmUgCm9udG8gdGhlIGFjdGl2ZV9saXN0LiBIb3cgY2FuIHR3 byBvZiB0aGVtIHJhY2U/CgpBbmQgYWxzbywgd2hhdCByZW1haW5zIHRvIGJlIHB1cnBvc2Ugb2Yg dGltZWxpbmVzLT5sb2NrPwoKUmVnYXJkcywKClR2cnRrbwoKCgoKCgoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==