From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Track fence region ID in plane state
Date: Thu, 02 Apr 2026 17:54:05 +0300 [thread overview]
Message-ID: <100e73f5d1363ca1b2269f6deeb67443727efaf4@intel.com> (raw)
In-Reply-To: <20260331162138.19258-1-ville.syrjala@linux.intel.com>
On Tue, 31 Mar 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> @@ -203,7 +204,7 @@ intel_fb_pin_to_ggtt(const struct drm_framebuffer *fb,
> ret = 0;
>
> if (vma->fence)
> - *out_flags |= PLANE_HAS_FENCE;
> + *out_fence_id |= vma->fence->id;
That should obviously be an assignment rather than OR.
I was reviewing the recently enabled Sashiko LLM reviews, and it had
spotted this one [1].
> @@ -314,7 +314,7 @@ int intel_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper,
> fb->min_alignment, 0,
> intel_fb_view_vtd_guard(&fb->base, &fb->normal_view,
> DRM_MODE_ROTATE_0),
> - false, &flags);
> + &fence_id);
This might also change behaviour as previously uses_fence == false.
BR,
Jani.
[1] https://sashiko.dev/#/patchset/20260331162138.19258-1-ville.syrjala%40linux.intel.com
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-04-02 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 16:21 [PATCH 1/2] drm/i915: Track fence region ID in plane state Ville Syrjala
2026-03-31 16:21 ` [PATCH 2/2] drm/i915: Remove the vma parent interface Ville Syrjala
2026-04-01 13:10 ` Jani Nikula
2026-03-31 17:15 ` ✗ i915.CI.BAT: failure for series starting with [1/2] drm/i915: Track fence region ID in plane state Patchwork
2026-04-01 13:10 ` [PATCH 1/2] " Jani Nikula
2026-04-01 14:29 ` Ville Syrjälä
2026-04-02 14:54 ` Jani Nikula [this message]
2026-04-02 17:20 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=100e73f5d1363ca1b2269f6deeb67443727efaf4@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox