From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Use
 i915_gem_object_get_dma_address() to populate rotated vmas
Date: Tue, 16 Oct 2018 18:54:59 +0100
Message-ID: <1038c59f-a630-6301-3f4d-bd81b188281d@linux.intel.com>
References: <20181016150413.11577-1-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 5447F6E278
 for <intel-gfx@lists.freedesktop.org>; Tue, 16 Oct 2018 17:55:05 +0000 (UTC)
In-Reply-To: <20181016150413.11577-1-ville.syrjala@linux.intel.com>
Content-Language: en-GB
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDE2LzEwLzIwMTggMTY6MDQsIFZpbGxlIFN5cmphbGEgd3JvdGU6Cj4gRnJvbTogVmlsbGUg
U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBSZXBsYWNlIHRo
ZSBrdm1hbGxvY19hcnJheSgpIHdpdGggaTkxNV9nZW1fb2JqZWN0X2dldF9kbWFfYWRkcmVzcygp
IHdoZW4KPiBwb3B1bGF0aW5nIHJvdGF0ZWQgdm1hcy4gT25lIHJhbmRvbSBhY2Nlc3MgbWVjaGFu
aXNtIG91Z2h0IHRvIGJlIGVub3VnaAo+IGZvciBldmVyeW9uZT8KPiAKPiBUbyBjYWxjdWxhdGUg
dGhlIHNpemUgb2YgdGhlIHJhZGl4IHRyZWUgSSB0aGluayB3ZSBjYW4gZG8KPiBzb21ldGhpbmcg
bGlrZSB0aGlzIChhc3N1bWluZyA2NGJpdCBwb2ludGVycyk6Cj4gICBudW1fcGFnZXMgPSBvYmpf
c2l6ZSAvIDQwOTYKPiAgIHRyZWVfaGVpZ2h0ID0gY2VpbChsb2c2NChudW1fcGFnZXMpKQo+ICAg
bnVtX25vZGVzID0gc3VtKDY0Xm4sIG4sIDAsIHRyZWVfaGVpZ2h0LTEpCj4gICB0cmVlX3NpemUg
PSBudW1fbm9kZXMgKiA1NzYKCkZvciAxOTIweDEwODB4NCBJIGdldCBhcm91bmQgMTlrIGluIHJl
YWwgbGlmZSAtIGRvZXMgdGhhdCBtYXRjaCB5b3VyIAptYXRoPyBGb3Igc29tZXRoaW5nIGxpa2Ug
dHdvIFVIRCBzY3JlZW5zIHdpdGggZG91YmxlIGJ1ZmZlcmluZyBJIGd1ZXNzIAp0aGF0J3MgYXJv
dW5kIDQgKiAyICogMiA9IDE2IHRpbWVzIG1vcmUsIHdoaWNoIGlzIHBlcmhhcHMgYSB3b3JzdCBj
YXNlIApzZXR1cD8gU28gfjMwMEtpQiBwZXJtYW5lbnRseSBwaW5uZWQgYW5kIGxpa2VseSBub3Qg
dXNlZCBwb3N0IGZpcnN0IHBpbiAKdG8gZGlzcGxheS4gSWYgdGhhdCBpcyBPSyB3aXRoIHlvdSB0
aGVuIHlvdSBoYXZlIG15IGFjayBmb3IgdGhlIHBhdGNoLiAKT3IgYSByZXZpZXcgaWYgeW91IGNh
biBsaXZlIHdpdGggc29tZSBkZWxheS4KClJlZ2FyZHMsCgpUdnJ0a28KCj4gSWYgd2UgY29tcGFy
ZSB0aGF0IHdpdGggdGhlIG9iamVjdCBzaXplIHdlIHNob3VsZCBnZXQgYSByZWxhdGl2ZQo+IG92
ZXJoZWFkIG9mIGFyb3VuZCAuMiUgdG8gMSUgZm9yIHJlYXNvbmFibGUgc2l6ZWQgb2JqZWN0cywK
PiB3aGljaCBmcmFtZWJ1ZmZlcnMgdGVuZCB0byBiZS4KPiAKPiBDYzogQ2hyaXMgV2lsc29uIDxj
aHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJz
dWxpbkBsaW51eC5pbnRlbC5jb20+Cj4gU3VnZ2VzdGVkLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlz
QGNocmlzLXdpbHNvbi5jby51az4KPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZp
bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5
MTUvaTkxNV9nZW1fZ3R0LmMgfCAzMSArKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAg
MSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMjUgZGVsZXRpb25zKC0pCj4gCj4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiBpbmRleCAyOWNhOTAwN2E3MDQuLjk4ZDlhMWVi
MWVkMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+
ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5jCj4gQEAgLTM2MzcsNyAr
MzYzNyw3IEBAIHZvaWQgaTkxNV9nZW1fcmVzdG9yZV9ndHRfbWFwcGluZ3Moc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgfQo+ICAgCj4gICBzdGF0aWMgc3RydWN0IHNjYXR0
ZXJsaXN0ICoKPiAtcm90YXRlX3BhZ2VzKGNvbnN0IGRtYV9hZGRyX3QgKmluLCB1bnNpZ25lZCBp
bnQgb2Zmc2V0LAo+ICtyb3RhdGVfcGFnZXMoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9i
aiwgdW5zaWduZWQgaW50IG9mZnNldCwKPiAgIAkgICAgIHVuc2lnbmVkIGludCB3aWR0aCwgdW5z
aWduZWQgaW50IGhlaWdodCwKPiAgIAkgICAgIHVuc2lnbmVkIGludCBzdHJpZGUsCj4gICAJICAg
ICBzdHJ1Y3Qgc2dfdGFibGUgKnN0LCBzdHJ1Y3Qgc2NhdHRlcmxpc3QgKnNnKQo+IEBAIC0zNjQ2
LDcgKzM2NDYsNyBAQCByb3RhdGVfcGFnZXMoY29uc3QgZG1hX2FkZHJfdCAqaW4sIHVuc2lnbmVk
IGludCBvZmZzZXQsCj4gICAJdW5zaWduZWQgaW50IHNyY19pZHg7Cj4gICAKPiAgIAlmb3IgKGNv
bHVtbiA9IDA7IGNvbHVtbiA8IHdpZHRoOyBjb2x1bW4rKykgewo+IC0JCXNyY19pZHggPSBzdHJp
ZGUgKiAoaGVpZ2h0IC0gMSkgKyBjb2x1bW47Cj4gKwkJc3JjX2lkeCA9IHN0cmlkZSAqIChoZWln
aHQgLSAxKSArIGNvbHVtbiArIG9mZnNldDsKPiAgIAkJZm9yIChyb3cgPSAwOyByb3cgPCBoZWln
aHQ7IHJvdysrKSB7Cj4gICAJCQlzdC0+bmVudHMrKzsKPiAgIAkJCS8qIFdlIGRvbid0IG5lZWQg
dGhlIHBhZ2VzLCBidXQgbmVlZCB0byBpbml0aWFsaXplCj4gQEAgLTM2NTQsNyArMzY1NCw4IEBA
IHJvdGF0ZV9wYWdlcyhjb25zdCBkbWFfYWRkcl90ICppbiwgdW5zaWduZWQgaW50IG9mZnNldCwK
PiAgIAkJCSAqIFRoZSBvbmx5IHRoaW5nIHdlIG5lZWQgYXJlIERNQSBhZGRyZXNzZXMuCj4gICAJ
CQkgKi8KPiAgIAkJCXNnX3NldF9wYWdlKHNnLCBOVUxMLCBJOTE1X0dUVF9QQUdFX1NJWkUsIDAp
Owo+IC0JCQlzZ19kbWFfYWRkcmVzcyhzZykgPSBpbltvZmZzZXQgKyBzcmNfaWR4XTsKPiArCQkJ
c2dfZG1hX2FkZHJlc3Moc2cpID0KPiArCQkJCWk5MTVfZ2VtX29iamVjdF9nZXRfZG1hX2FkZHJl
c3Mob2JqLCBzcmNfaWR4KTsKPiAgIAkJCXNnX2RtYV9sZW4oc2cpID0gSTkxNV9HVFRfUEFHRV9T
SVpFOwo+ICAgCQkJc2cgPSBzZ19uZXh0KHNnKTsKPiAgIAkJCXNyY19pZHggLT0gc3RyaWRlOwo+
IEBAIC0zNjY4LDIyICszNjY5LDExIEBAIHN0YXRpYyBub2lubGluZSBzdHJ1Y3Qgc2dfdGFibGUg
Kgo+ICAgaW50ZWxfcm90YXRlX3BhZ2VzKHN0cnVjdCBpbnRlbF9yb3RhdGlvbl9pbmZvICpyb3Rf
aW5mbywKPiAgIAkJICAgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikKPiAgIHsKPiAt
CWNvbnN0IHVuc2lnbmVkIGxvbmcgbl9wYWdlcyA9IG9iai0+YmFzZS5zaXplIC8gSTkxNV9HVFRf
UEFHRV9TSVpFOwo+ICAgCXVuc2lnbmVkIGludCBzaXplID0gaW50ZWxfcm90YXRpb25faW5mb19z
aXplKHJvdF9pbmZvKTsKPiAtCXN0cnVjdCBzZ3RfaXRlciBzZ3RfaXRlcjsKPiAtCWRtYV9hZGRy
X3QgZG1hX2FkZHI7Cj4gLQl1bnNpZ25lZCBsb25nIGk7Cj4gLQlkbWFfYWRkcl90ICpwYWdlX2Fk
ZHJfbGlzdDsKPiAgIAlzdHJ1Y3Qgc2dfdGFibGUgKnN0Owo+ICAgCXN0cnVjdCBzY2F0dGVybGlz
dCAqc2c7Cj4gICAJaW50IHJldCA9IC1FTk9NRU07Cj4gLQo+IC0JLyogQWxsb2NhdGUgYSB0ZW1w
b3JhcnkgbGlzdCBvZiBzb3VyY2UgcGFnZXMgZm9yIHJhbmRvbSBhY2Nlc3MuICovCj4gLQlwYWdl
X2FkZHJfbGlzdCA9IGt2bWFsbG9jX2FycmF5KG5fcGFnZXMsCj4gLQkJCQkJc2l6ZW9mKGRtYV9h
ZGRyX3QpLAo+IC0JCQkJCUdGUF9LRVJORUwpOwo+IC0JaWYgKCFwYWdlX2FkZHJfbGlzdCkKPiAt
CQlyZXR1cm4gRVJSX1BUUihyZXQpOwo+ICsJaW50IGk7Cj4gICAKPiAgIAkvKiBBbGxvY2F0ZSB0
YXJnZXQgU0cgbGlzdC4gKi8KPiAgIAlzdCA9IGttYWxsb2Moc2l6ZW9mKCpzdCksIEdGUF9LRVJO
RUwpOwo+IEBAIC0zNjk0LDI5ICszNjg0LDIwIEBAIGludGVsX3JvdGF0ZV9wYWdlcyhzdHJ1Y3Qg
aW50ZWxfcm90YXRpb25faW5mbyAqcm90X2luZm8sCj4gICAJaWYgKHJldCkKPiAgIAkJZ290byBl
cnJfc2dfYWxsb2M7Cj4gICAKPiAtCS8qIFBvcHVsYXRlIHNvdXJjZSBwYWdlIGxpc3QgZnJvbSB0
aGUgb2JqZWN0LiAqLwo+IC0JaSA9IDA7Cj4gLQlmb3JfZWFjaF9zZ3RfZG1hKGRtYV9hZGRyLCBz
Z3RfaXRlciwgb2JqLT5tbS5wYWdlcykKPiAtCQlwYWdlX2FkZHJfbGlzdFtpKytdID0gZG1hX2Fk
ZHI7Cj4gLQo+IC0JR0VNX0JVR19PTihpICE9IG5fcGFnZXMpOwo+ICAgCXN0LT5uZW50cyA9IDA7
Cj4gICAJc2cgPSBzdC0+c2dsOwo+ICAgCj4gICAJZm9yIChpID0gMCA7IGkgPCBBUlJBWV9TSVpF
KHJvdF9pbmZvLT5wbGFuZSk7IGkrKykgewo+IC0JCXNnID0gcm90YXRlX3BhZ2VzKHBhZ2VfYWRk
cl9saXN0LCByb3RfaW5mby0+cGxhbmVbaV0ub2Zmc2V0LAo+ICsJCXNnID0gcm90YXRlX3BhZ2Vz
KG9iaiwgcm90X2luZm8tPnBsYW5lW2ldLm9mZnNldCwKPiAgIAkJCQkgIHJvdF9pbmZvLT5wbGFu
ZVtpXS53aWR0aCwgcm90X2luZm8tPnBsYW5lW2ldLmhlaWdodCwKPiAgIAkJCQkgIHJvdF9pbmZv
LT5wbGFuZVtpXS5zdHJpZGUsIHN0LCBzZyk7Cj4gICAJfQo+ICAgCj4gLQlrdmZyZWUocGFnZV9h
ZGRyX2xpc3QpOwo+IC0KPiAgIAlyZXR1cm4gc3Q7Cj4gICAKPiAgIGVycl9zZ19hbGxvYzoKPiAg
IAlrZnJlZShzdCk7Cj4gICBlcnJfc3RfYWxsb2M6Cj4gLQlrdmZyZWUocGFnZV9hZGRyX2xpc3Qp
Owo+ICAgCj4gICAJRFJNX0RFQlVHX0RSSVZFUigiRmFpbGVkIHRvIGNyZWF0ZSByb3RhdGVkIG1h
cHBpbmcgZm9yIG9iamVjdCBzaXplICV6dSEgKCV1eCV1IHRpbGVzLCAldSBwYWdlcylcbiIsCj4g
ICAJCQkgb2JqLT5iYXNlLnNpemUsIHJvdF9pbmZvLT5wbGFuZVswXS53aWR0aCwgcm90X2luZm8t
PnBsYW5lWzBdLmhlaWdodCwgc2l6ZSk7Cj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz
LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp
c3RpbmZvL2ludGVsLWdmeAo=