From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Souza, Jose" <jose.souza@intel.com>
Subject: Re: [PATCH v2 5/5] drm/i915/icl: Fix port B combo PHY
 context loss after DC transitions
Date: Wed, 7 Nov 2018 20:46:53 +0000
Message-ID: <106e908eccf9b3ecef83a044df4f275c6eba671b.camel@intel.com>
References: <20181106160621.23057-1-imre.deak@intel.com>
 <20181106160621.23057-6-imre.deak@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1488663135=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id DCDCC6E4B7
 for <intel-gfx@lists.freedesktop.org>; Wed,  7 Nov 2018 20:46:54 +0000 (UTC)
In-Reply-To: <20181106160621.23057-6-imre.deak@intel.com>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "Deak, Imre" <imre.deak@intel.com>
Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>, "Vivi,
 Rodrigo" <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

--===============1488663135==
Content-Language: en-US
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-geJziuInmRF2FpvQsRmH"

--=-geJziuInmRF2FpvQsRmH
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2018-11-06 at 18:06 +0200, Imre Deak wrote:
> On ICL DMC/PCODE retains the HW context only for port A across DC
> transitions, for the other port B combo PHY, it doesn't. So we need
> to
> do this manually after exiting from DC6. Do the reinit even after
> exiting from DC5, it won't hurt since we only reinit the PHY in case
> it's needed (in case it was disabled to begin with).
>=20
> As can be guessed from the bugzilla report leaving the PHY uninited
> will
> lead to a later timeout during the port B specific AUX and DDI_IO
> power
> well enabling.
>=20
> v2:
> - Apply the fix on all GEN>=3D11 platforms. (Rodrigo)
>=20
> Bspec: 21257
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D108070
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Ville Syrj=C3=A4l=C3=A4 <ville.syrjala@linux.intel.com>

Reviewed-by: Jos=C3=A9 Roberto de Souza <jose.souza@intel.com>

> Cc: Jos=C3=A9 Roberto de Souza <jose.souza@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_runtime_pm.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>=20
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
> b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index f8da471e81aa..c20f25d6964a 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -843,6 +843,14 @@ static void gen9_dc_off_power_well_enable(struct
> drm_i915_private *dev_priv,
> =20
>  	if (IS_GEN9_LP(dev_priv))
>  		bxt_verify_ddi_phy_power_wells(dev_priv);
> +
> +	if (INTEL_GEN(dev_priv) >=3D 11)
> +		/*
> +		 * DMC retains HW context only for port A, the other
> combo
> +		 * PHY's HW context for port B is lost after DC
> transitions,
> +		 * so we need to restore it manually.
> +		 */
> +		icl_combo_phys_init(dev_priv);
>  }
> =20
>  static void gen9_dc_off_power_well_disable(struct drm_i915_private
> *dev_priv,

--=-geJziuInmRF2FpvQsRmH
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEVNG051EijGa0MiaQVenbO/mOWkkFAlvjTzsACgkQVenbO/mO
WkmzvAf/TkHBmkLIFpXvdg14b+AbnOzv5Hecbg4Khhwx1Ls7yKijNzguHbw7PrET
1EnD4Llp2TZ9ZDutyrVs9t1BhNGaMFWOl+6iLrb7a3YY0qhz82KG2jwo+bdsAWuO
GPG3/2pKBrwk5QMWUd3WqYQh0AFkvHMjv/KhP+CRn4CHM1HXvJGAu1AJpLUp2g0u
lDnTcOnwLetNE/WZJ5nsyR+4zwMmvbmgekBT2LAOWNF4g7sq/oI2w3zKOjtTXjDC
G/fp54wg/zxizr7xi+j78Pi4cZYHcdbFioVoC18rJ3J3vcckoLKcLaE77Dbf5+7r
ozn3zZuQ5Z+6nhj1TlRpSPFGRPMHnQ==
=pUGd
-----END PGP SIGNATURE-----

--=-geJziuInmRF2FpvQsRmH--

--===============1488663135==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==

--===============1488663135==--