From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3F7FC2D0E4 for ; Tue, 17 Nov 2020 11:42:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40A6C2065D for ; Tue, 17 Nov 2020 11:42:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40A6C2065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD1E86E1A2; Tue, 17 Nov 2020 11:42:46 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4786A6E1A2 for ; Tue, 17 Nov 2020 11:42:45 +0000 (UTC) IronPort-SDR: PwibQhyhwD2sPOB0qdoExOTRN3j5a63YSsZ0RFkW4GyyVfaytQHfR9PYWChl0xcZQxwim8imXl 9a0mFcHASgbw== X-IronPort-AV: E=McAfee;i="6000,8403,9807"; a="170124285" X-IronPort-AV: E=Sophos;i="5.77,485,1596524400"; d="scan'208";a="170124285" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 03:42:44 -0800 IronPort-SDR: pTLYU2me4YZFFLdCbkGz0nuo+CuiUAajAE2ysGua1Eil4kybaZhyCqBevYMmVOwMV/jvy5JNdz URQeLWyrCyXA== X-IronPort-AV: E=Sophos;i="5.77,485,1596524400"; d="scan'208";a="544015877" Received: from jgagatko-mobl1.ger.corp.intel.com (HELO [10.252.50.93]) ([10.252.50.93]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 03:42:43 -0800 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20201117113103.21480-1-chris@chris-wilson.co.uk> <20201117113103.21480-4-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <11644cd7-35a5-551b-7932-0ad1fc362557@linux.intel.com> Date: Tue, 17 Nov 2020 11:42:41 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201117113103.21480-4-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 04/28] drm/i915/gt: Ignore dt==0 for reporting underflows X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 17/11/2020 11:30, Chris Wilson wrote: > The presumption was that some time would always elapse between recording > the start and the finish of a context switch. This turns out to be a > regular occurrence and emitting a debug statement superfluous. > > Signed-off-by: Chris Wilson > Cc: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > index 8a51c1c3a091..52b84474f93a 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > @@ -1307,7 +1307,7 @@ static void reset_active(struct i915_request *rq, > static void st_update_runtime_underflow(struct intel_context *ce, s32 dt) > { > #if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) > - ce->runtime.num_underflow += dt < 0; > + ce->runtime.num_underflow++; > ce->runtime.max_underflow = max_t(u32, ce->runtime.max_underflow, -dt); > #endif > } > @@ -1324,7 +1324,7 @@ static void intel_context_update_runtime(struct intel_context *ce) > ce->runtime.last = intel_context_get_runtime(ce); > dt = ce->runtime.last - old; > > - if (unlikely(dt <= 0)) { > + if (unlikely(dt < 0)) { > CE_TRACE(ce, "runtime underflow: last=%u, new=%u, delta=%d\n", > old, ce->runtime.last, dt); > st_update_runtime_underflow(ce, dt); > Reviewed-by: Tvrtko Ursulin Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx