From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] drm/i915/vlv: Fix off-by-1 error in calculating num_levels. Date: Mon, 25 Jul 2016 13:32:45 +0200 Message-ID: <12173c41-da78-99df-dec6-33b41deab9db@linux.intel.com> References: <1466685388-16504-1-git-send-email-chix.ding@intel.com> <20160719152542.GN4329@intel.com> <20160719155049.GL17604@nuc-i3427.alporthouse.com> <20160719162132.GO4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 0ABA46E371 for ; Mon, 25 Jul 2016 11:32:48 +0000 (UTC) In-Reply-To: <20160719162132.GO4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Chris Wilson , yetundex.adebisi@intel.com, isg-gms@eclists.intel.com, Chi Ding , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGV5LAoKT3AgMTktMDctMTYgb20gMTg6MjEgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24g VHVlLCBKdWwgMTksIDIwMTYgYXQgMDQ6NTA6NDlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdyb3Rl Ogo+PiBPbiBUdWUsIEp1bCAxOSwgMjAxNiBhdCAwNjoyNTo0MlBNICswMzAwLCBWaWxsZSBTeXJq w6Rsw6Qgd3JvdGU6Cj4+PiBPbiBUdWUsIEp1bCAxOSwgMjAxNiBhdCAwNToxNDoyM1BNICswMjAw LCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPj4+PiBudW1fbGV2ZWxzIHNob3VsZCBiZSBsZXZl bCsxLCBub3QgbGV2ZWwsIGVsc2UgbnVtX2xldmVscyAtIDEgYmVjb21lcwo+Pj4+IG5lZ2F0aXZl LiBUaGlzIHJlc3VsdGVkIGluIGJvZ3VzIHdhdGVybWFya3MgYmVpbmcgd3JpdHRlbiB0byB0aGUg Zmlyc3QKPj4+PiAyNTUgbGV2ZWxzIGxpa2UgYmVsb3c6Cj4+Pj4KPj4+PiBbZHJtXSBTZXR0aW5n IEZJRk8gd2F0ZXJtYXJrcyAtIEM6IHBsYW5lPTAsIGN1cnNvcj0wLCBzcHJpdGUwPTAsIHNwcml0 ZTE9MCwgU1I6IHBsYW5lPTAsIGN1cnNvcj0wIGxldmVsPTI1NSBjeHNyPTAKPj4+PiBbZHJtOmNo dl9zZXRfbWVtb3J5X2R2ZnMgW2k5MTVdXSAqRVJST1IqIHRpbWVkIG91dCB3YWl0aW5nIGZvciBQ dW5pdCBERFIgRFZGUyByZXF1ZXN0Cj4+Pj4gW2RybTppbnRlbF9jcHVfZmlmb191bmRlcnJ1bl9p cnFfaGFuZGxlciBbaTkxNV1dICpFUlJPUiogQ1BVIHBpcGUgQyBGSUZPIHVuZGVycnVuCj4+Pj4g W2RybTpjaHZfc2V0X21lbW9yeV9kdmZzIFtpOTE1XV0gKkVSUk9SKiB0aW1lZCBvdXQgd2FpdGlu ZyBmb3IgUHVuaXQgRERSIERWRlMgcmVxdWVzdAo+Pj4+Cj4+Pj4gVGVzdGNhc2U6IGttc19hdG9t aWNfdHJhbnNpdGlvbgo+Pj4+IEZpeGVzOiAyNjJjZDJlMTU0YzIgKCJkcm0vaTkxNTogQ0hWIERE UiBEVkZTIHN1cHBvcnQgYW5kIGFub3RoZXIgd2F0ZXJtYXJrIHJld3JpdGUiKQo+Pj4+IENjOiBz dGFibGVAdmdlci5rZXJuZWwub3JnCj4+Pj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9y c3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPj4+PiAtLS0KPj4+PiBVcmdl bnQgZml4IGZvciB3YXRlcm1hcmsgc3VwcG9ydC4gVGhpcyBpcyBkZWZpbml0ZWx5IGEgcHJlLXJl cXVpc2l0ZSBmb3IgdGhpcyBzZXJpZXMuCj4+Pj4gV2l0aCB0aGlzIEkndmUgbm90aWNlZCB0aGF0 IHBhdGNoICJbUkZDIDMvOF0gZHJtL2k5MTUvdmx2OiBNb3ZlIGZpZm9fc2l6ZSBmcm9tCj4+Pj4g aW50ZWxfcGxhbmVfd21fcGFyYW1ldGVycyB0byB2bHZfd21fc3RhdGUiIGludHJvZHVjZXMgYSBy ZWdyZXNzaW9uIHdpdGggaW52YWxpZCBGSUZPIHNwbGl0Lgo+Pj4+Cj4+Pj4gSSBuZWVkIHRvIGZp bmQgb3V0IHdoYXQncyBnb2luZyB3cm9uZyBpbiB0aGF0IHBhdGNoIGJlZm9yZSB0aGlzIHNlcmll cyBjYW4gYmUgYXBwbGllZC4KPj4+Pgo+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9w bS5jIHwgMiArLQo+Pj4+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRp b24oLSkKPj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9w bS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+Pj4+IGluZGV4IDM3NmM2MGI5 ODUxNS4uOGRlZmRjYzU0NTI5IDEwMDY0NAo+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3BtLmMKPj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4+ Pj4gQEAgLTExNDgsNyArMTE0OCw3IEBAIHN0YXRpYyB2b2lkIHZsdl9jb21wdXRlX3dtKHN0cnVj dCBpbnRlbF9jcnRjICpjcnRjKQo+Pj4+ICAJCQl9Cj4+Pj4gIAkJfQo+Pj4+ICAKPj4+PiAtCQl3 bV9zdGF0ZS0+bnVtX2xldmVscyA9IGxldmVsOwo+Pj4+ICsJCXdtX3N0YXRlLT5udW1fbGV2ZWxz ID0gbGV2ZWwgKyAxOwo+Pj4gTm9wZS4gVGhlIGxvb3AgYWJvdmUgYnJlYWtzIHdoZW4gdGhlIGN1 cnJlbnQgbGV2ZWwgaXMgYmFkLCBoZW5jZSBsZXZlbC0xCj4+PiBpcyBhY3R1YWxseSB0aGUgaGln aGVyIHVzYWJsZSBsZXZlbC4KPj4gV2l0aG91dCBrbm93aW5nIHRoZSBsaW1pdHMgb2YgcGxhbmUt PndtLmZpZm9fc2l6ZSwgaXQgbG9va3MgbGlrZSBpdCBjYW4KPj4gYnJlYWsgb24gbGV2ZWwgPT0g MCB0aG91Z2guCj4gSG1tLiBUaGF0IHNob3VsZG4ndCBiZSBwb3NzaWJsZS4gU28gbG9va3MgbGlr ZSBhIGJ1ZyBzbnVjayBpbi4KPgo+PiBNaWdodCBhcyB3ZWxsIHNldCB0aGF0IGhhY2sgdG8gcGFy YW5vaWQgbGV2ZWxzOgo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPj4gaW5kZXggNjMwYjEx Njk4OGY2Li5lOGMyODc0Yjg2MjkgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3BtLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+PiBA QCAtMTEyNCwxMSArMTEyNCwxMyBAQCBzdGF0aWMgdm9pZCB2bHZfY29tcHV0ZV93bShzdHJ1Y3Qg aW50ZWxfY3J0YyAqY3J0YykKPj4gICAgICAgICAgICAgICAgIC8qIG5vcm1hbCB3YXRlcm1hcmtz ICovCj4+ICAgICAgICAgICAgICAgICBmb3IgKGxldmVsID0gMDsgbGV2ZWwgPCB3bV9zdGF0ZS0+ bnVtX2xldmVsczsgbGV2ZWwrKykgewkKPj4gICAgICAgICAgICAgICAgICAgICAgICAgaW50IHdt ID0gdmx2X2NvbXB1dGVfd21fbGV2ZWwocGxhbmUsIGNydGMsIHN0YXRlLCBsZXZlbCk7Cj4+IC0g ICAgICAgICAgICAgICAgICAgICAgIGludCBtYXhfd20gPSBwbGFuZS0+YmFzZS50eXBlID09IERS TV9QTEFORV9UWVBFX0NVUlNPUiA/IDYzIDogNTExOwo+PiAtCj4+ICAgICAgICAgICAgICAgICAg ICAgICAgIC8qIGhhY2sgKi8KPj4gLSAgICAgICAgICAgICAgICAgICAgICAgaWYgKFdBUk5fT04o bGV2ZWwgPT0gMCAmJiB3bSA+IG1heF93bSkpCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgd20gPSBtYXhfd207Cj4gQWN0dWFsbHkgdGhpcyBzaG91bGQganVzdCBiZSAKPgo+IGlm IChXQVJOX09OKGxldmVsID09IDAgJiYgd20gPiBmaWZvX3NpemUpKQo+IAl3bSA9IGZpZm9fc2l6 ZTsKPgo+IGFzc3VtaW5nIHdlIHdhbnQgdG8ga2VlcCB0aGUgaGFjayBhcm91bmQgZm9yIG5vdy4K Pgo+IEV2ZW50dWFsbHkgd2UnbGwgd2FudCB0byBtYWtlIGl0IGp1c3QgcmV0dXJuIGFuIGVycm9y IHRob3VnaC4KWWVzLCB0aGF0J3Mgd2hhdCBJIGNhbWUgdXAgd2l0aC4KCkJ1dCB3ZSBzdGlsbCBu ZWVkIHRvIGNsYW1wIGZ1cnRoZXIsIHByb2JhYmx5IHRvIHBsYW5lLT53bS5maWZvX3NpemUuCkhv d2V2ZXIgc3JfZmlmb19zaXplIGlzIGFsc28gY2xhbXBlZCB0byA1MTEgYmVjYXVzZSBvZiB0aGUg bGV2ZWwgY2FsY3VsYXRpb25zIGhlcmUuCgpCZWxvdyBpdCBzZXRzIHNyW2xldmVsXS5wbGFuZSA9 IG1pbihzcl9maWZvX3NpemUsIHdtW2xldmVsXS5wbGFuZSksCndoaWNoIHNlZW1zIHdlaXJkLiBI b3cgY2FuIHRoaXMgZXZlciBlbmQgdXAgYmVpbmcgc29tZXRoaW5nIG90aGVyIHRoYW4gd21bbGV2 ZWxdLnBsYW5lPwpCZWNhdXNlIHNyX2ZpZm9fc2l6ZSA+PSBtYXhfd20gaXMgYWx3YXlzIHRydWUu CgpJIGd1ZXNzIHZsdl9pbnZlcnRfd21zIHdpbGwgaW52ZXJ0IGl0LCBidXQgd2UgY291bGQgc2lt cGx5IG9ubHkgc2V0IGl0IHRoZXJlIHRoZW4sIG9yIHJlbW92ZSB0aGUgbWluKCkuLgoKfk1hYXJ0 ZW4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==