From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16812C433E0 for ; Wed, 6 Jan 2021 15:13:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2DCD22C9F for ; Wed, 6 Jan 2021 15:13:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2DCD22C9F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E12216E05F; Wed, 6 Jan 2021 15:13:02 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 87FF96E05F for ; Wed, 6 Jan 2021 15:13:01 +0000 (UTC) IronPort-SDR: gwF3gYoL/2RhL51yB4wrimHargORn1TfSQXsiCrVPdl2bu5lq0bCyFidl1vzBjqUwmVIoga0rM TZaIfJl4Xjrg== X-IronPort-AV: E=McAfee;i="6000,8403,9855"; a="176510014" X-IronPort-AV: E=Sophos;i="5.78,480,1599548400"; d="scan'208";a="176510014" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 07:13:01 -0800 IronPort-SDR: XvC2TgDXPPnGd3SdhjY2CiYtMhlPjz05+jC9bYGlFSAxrrsREXysEwA1QgEvr09nv/XWXU7oI8 1ctHy4V2H6VA== X-IronPort-AV: E=Sophos;i="5.78,480,1599548400"; d="scan'208";a="422193872" Received: from vbratanx-mobl.ger.corp.intel.com (HELO [10.252.38.40]) ([10.252.38.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 07:13:00 -0800 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20210106123939.18435-1-chris@chris-wilson.co.uk> <20210106123939.18435-2-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <1274dd24-c55b-3031-8108-4918a4600db6@linux.intel.com> Date: Wed, 6 Jan 2021 15:12:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210106123939.18435-2-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 2/4] drm/i915/selftests: Improve handling of iomem around stolen X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 06/01/2021 12:39, Chris Wilson wrote: > Use memset_io() on the iomem, and silence sparse as we copy from the > iomem to normal system pages. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/gt/selftest_reset.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/selftest_reset.c b/drivers/gpu/drm/i915/gt/selftest_reset.c > index 5ec8d4e9983f..b7befcfbdcde 100644 > --- a/drivers/gpu/drm/i915/gt/selftest_reset.c > +++ b/drivers/gpu/drm/i915/gt/selftest_reset.c > @@ -96,10 +96,10 @@ __igt_reset_stolen(struct intel_gt *gt, > if (!__drm_mm_interval_first(>->i915->mm.stolen, > page << PAGE_SHIFT, > ((page + 1) << PAGE_SHIFT) - 1)) > - memset32(s, STACK_MAGIC, PAGE_SIZE / sizeof(u32)); > + memset_io(s, STACK_MAGIC, PAGE_SIZE); > > - in = s; > - if (i915_memcpy_from_wc(tmp, s, PAGE_SIZE)) > + in = (void __force *)s; > + if (i915_memcpy_from_wc(tmp, in, PAGE_SIZE)) > in = tmp; > crc[page] = crc32_le(0, in, PAGE_SIZE); > > @@ -134,8 +134,8 @@ __igt_reset_stolen(struct intel_gt *gt, > ggtt->error_capture.start, > PAGE_SIZE); > > - in = s; > - if (i915_memcpy_from_wc(tmp, s, PAGE_SIZE)) > + in = (void __force *)s; > + if (i915_memcpy_from_wc(tmp, in, PAGE_SIZE)) > in = tmp; > x = crc32_le(0, in, PAGE_SIZE); > > Reviewed-by: Tvrtko Ursulin Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx