From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Clifton Subject: Re: i915_gem_evict_something in sysprof trace using VBOs Date: Fri, 05 Nov 2010 14:30:35 +0000 Message-ID: <1288967435.11782.31.camel@pcjc2lap> References: <1288952467.24411.44.camel@pcjc2lap> <5b55a1$iitkru@fmsmga002.fm.intel.com> <1288957454.4728.19.camel@pcjc2lap> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-+V6ZKS1ZnxBtMBqaXgMi" Return-path: Received: from ppsw-50.csi.cam.ac.uk (ppsw-50.csi.cam.ac.uk [131.111.8.150]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F2439E79D for ; Fri, 5 Nov 2010 07:30:38 -0700 (PDT) In-Reply-To: <1288957454.4728.19.camel@pcjc2lap> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: "intel-gfx@lists.freedesktop.org" , "mesa3d-dev@lists.sourceforge.net" List-Id: intel-gfx@lists.freedesktop.org --=-+V6ZKS1ZnxBtMBqaXgMi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2010-11-05 at 11:44 +0000, Peter Clifton wrote: > I take bets its "something I've done wrong", as usually seems to be the > way, but for now - if I just use glBufferSubData to upload changed data > only, I get rendering corruption. It works fine with > LIBGL_ALWAYS_SOFTWARE=1 though, so there is perhaps a small possibility > of a driver bug? Does this look correct? Forcing the Gen6 fallback for BufferSubData fixes my corruption. Seems as if the blit is going wrong. The PRM suggests the pitch needs to be DWORD aligned, The attached patch fixes it. What I can't quite fathom is how this has escaped until now.. am I doing something unusual by calling glBufferSubData with large buffers? Could someone with access to MESA repositories review and commit it please? -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) --=-+V6ZKS1ZnxBtMBqaXgMi Content-Disposition: attachment; filename*0=0001-intel-Fix-emit_linear_blit-to-use-DWORD-aligned-widt.pat; filename*1=ch Content-Type: text/x-patch; name="0001-intel-Fix-emit_linear_blit-to-use-DWORD-aligned-widt.patch"; charset="UTF-8" Content-Transfer-Encoding: 7bit >>From 055cd27dbdf225c084f4bc2254763dba016edd50 Mon Sep 17 00:00:00 2001 From: Peter Clifton Date: Fri, 5 Nov 2010 14:26:24 +0000 Subject: [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits The width of the 2D blits used to copy the data is defined as a 16-bit signed integer, but the pitch must be DWORD aligned. Limit to an integral number of DWORDs, (1 << 15 - 4) rather than (1 << 15 -1). Fixes corruption to data uploaded with glBufferSubData. Signed-off-by: Peter Clifton --- src/mesa/drivers/dri/intel/intel_blit.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_blit.c b/src/mesa/drivers/dri/intel/intel_blit.c index a74e217..4dc8888 100644 --- a/src/mesa/drivers/dri/intel/intel_blit.c +++ b/src/mesa/drivers/dri/intel/intel_blit.c @@ -483,8 +483,11 @@ intel_emit_linear_blit(struct intel_context *intel, /* Blits are in a different ringbuffer so we don't use them. */ assert(intel->gen < 6); - /* The pitch is a signed value. */ - pitch = MIN2(size, (1 << 15) - 1); + /* The pitch hits the GPU as a is a signed value, IN DWORDs. + * But we want width to match pitch. Max width is (1 << 15 -1), + * rounding that down to the nearest DWORD is 1 << 15 - 3 + */ + pitch = MIN2(size, (1 << 15) - 4); height = size / pitch; ok = intelEmitCopyBlit(intel, 1, pitch, src_bo, src_offset, I915_TILING_NONE, -- 1.7.1 --=-+V6ZKS1ZnxBtMBqaXgMi Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --=-+V6ZKS1ZnxBtMBqaXgMi--