From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Clifton Subject: Re: [PATCH] drm/i915: Fix restore of 965 fence regs since the register tracing change. Date: Mon, 22 Nov 2010 14:18:39 +0000 Message-ID: <1290435519.7760.1.camel@pcjc2lap> References: <1290045900-4012-1-git-send-email-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from ppsw-52.csi.cam.ac.uk (ppsw-52.csi.cam.ac.uk [131.111.8.152]) by gabe.freedesktop.org (Postfix) with ESMTP id BCD1A9E79A for ; Mon, 22 Nov 2010 06:18:46 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 2010-11-22 at 12:13 +0000, Chris Wilson wrote: > On Thu, 18 Nov 2010 11:47:12 +0800, Keith Packard wrote: > > > > We were reading our 64-bit value in I915_READ64 and returning 32 bits > > of it. The restoration of fence regs at resume then had a zero end > > value, and the fence had no effect. > > It was a good catch. Applied one final tweak to use macros to generate > the various read/write routines and applied to -next. > -Chris Chris, does this sound like it might be behind the bug I mentioned on IRC? -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)