From: Cyril Brulebois <kibi@debian.org>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 3/5] xvmc: Silence gcc, add parentheses around arithmetic.
Date: Mon, 31 Jan 2011 06:22:37 +0100 [thread overview]
Message-ID: <1296451359-28449-3-git-send-email-kibi@debian.org> (raw)
In-Reply-To: <1296451359-28449-1-git-send-email-kibi@debian.org>
Get rid of those accordingly with CFLAGS="-Wall -Werror":
| CC i915_xvmc.lo
| cc1: warnings being treated as errors
| i915_xvmc.c: In function ‘i915_mc_one_time_state_emit’:
| i915_xvmc.c:369: error: suggest parentheses around arithmetic in operand of ‘|’
| i915_xvmc.c:374: error: suggest parentheses around arithmetic in operand of ‘|’
| i915_xvmc.c:379: error: suggest parentheses around arithmetic in operand of ‘|’
| i915_xvmc.c: In function ‘i915_mc_load_indirect_render_emit’:
| i915_xvmc.c:708: error: suggest parentheses around arithmetic in operand of ‘|’
| i915_xvmc.c:713: error: suggest parentheses around arithmetic in operand of ‘|’
Signed-off-by: Cyril Brulebois <kibi@debian.org>
---
src/xvmc/i915_xvmc.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/xvmc/i915_xvmc.c b/src/xvmc/i915_xvmc.c
index fbd4555..dc3b593 100644
--- a/src/xvmc/i915_xvmc.c
+++ b/src/xvmc/i915_xvmc.c
@@ -367,17 +367,17 @@ static void i915_mc_one_time_state_emit(XvMCContext * context)
/* Sample state buffer */
OUT_RELOC(pI915XvMC->ssb_bo, I915_GEM_DOMAIN_INSTRUCTION, 0,
- STATE_VALID | STATE_FORCE);
+ (STATE_VALID | STATE_FORCE));
OUT_BATCH(7); /* 8 - 1 */
/* Pixel shader program buffer */
OUT_RELOC(pI915XvMC->psp_bo, I915_GEM_DOMAIN_INSTRUCTION, 0,
- STATE_VALID | STATE_FORCE);
+ (STATE_VALID | STATE_FORCE));
OUT_BATCH(66); /* 4 + 16 + 16 + 31 - 1 */
/* Pixel shader constant buffer */
OUT_RELOC(pI915XvMC->psc_bo, I915_GEM_DOMAIN_INSTRUCTION, 0,
- STATE_VALID | STATE_FORCE);
+ (STATE_VALID | STATE_FORCE));
OUT_BATCH(5); /* 6 - 1 */
ADVANCE_BATCH();
}
@@ -705,12 +705,12 @@ static void i915_mc_load_indirect_render_emit(XvMCContext * context)
/* Static Indirect state buffer (dest buffer info) */
OUT_RELOC(pI915XvMC->sis_bo, I915_GEM_DOMAIN_INSTRUCTION, 0,
- STATE_VALID | STATE_FORCE);
+ (STATE_VALID | STATE_FORCE));
OUT_BATCH(16); /* 4 * 3 + 2 + 3 - 1 */
/* Map state buffer (reference buffer info) */
OUT_RELOC(pI915XvMC->msb_bo, I915_GEM_DOMAIN_INSTRUCTION, 0,
- STATE_VALID | STATE_FORCE);
+ (STATE_VALID | STATE_FORCE));
OUT_BATCH(23); /* 3 * 8 - 1 */
ADVANCE_BATCH();
}
--
1.7.2.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2011-01-31 5:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 5:22 [PATCH 1/5] xvmc: Get rid of unused variables Cyril Brulebois
2011-01-31 5:22 ` [PATCH 2/5] xvmc: Silence gcc, add parentheses around assignment Cyril Brulebois
2011-01-31 5:22 ` Cyril Brulebois [this message]
2011-01-31 9:50 ` [PATCH 3/5] xvmc: Silence gcc, add parentheses around arithmetic Chris Wilson
2011-01-31 9:55 ` Julien Cristau
2011-01-31 5:22 ` [PATCH 4/5] xvmc: Silence gcc, adding a cast to work around signedness issues Cyril Brulebois
2011-01-31 5:22 ` [PATCH 5/5] xvmc: Stop using uninitialized variable Cyril Brulebois
2011-01-31 10:05 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296451359-28449-3-git-send-email-kibi@debian.org \
--to=kibi@debian.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox