From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Menzel Subject: Re: [PATCH] drm/i915: error_buffer->ring should be signed Date: Thu, 16 Feb 2012 11:18:53 +0100 Message-ID: <1329387533.3518.46.camel@mattotaupa> References: <20120216064004.GA23794@elgon.mountain> <1329386609-15885-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0733484164==" Return-path: In-Reply-To: <1329386609-15885-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org Cc: Vetter , Intel Graphics Development , Daniel@freedesktop.org, Dan Carpenter List-Id: intel-gfx@lists.freedesktop.org --===============0733484164== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-om7Pex5E2IwzGwwEp8rO" --=-om7Pex5E2IwzGwwEp8rO Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Am Donnerstag, den 16.02.2012, 11:03 +0100 schrieb Daniel Vetter: > gcc seems to get uber-anal recently about these things. which was introduced by the following commit. 96154f2faba5: "drm/i915: switch ring->id to be a real id" > Reported-by: Dan Carpenter The URL of the report is the following. http://lists.freedesktop.org/archives/dri-devel/2012-February/019183.html > Signed-off-by: Daniel Vetter Acked-by: Paul Menzel > --- > drivers/gpu/drm/i915/i915_drv.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_= drv.h > index b839728..35833fc 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -199,7 +199,7 @@ struct drm_i915_error_state { > u32 tiling:2; > u32 dirty:1; > u32 purgeable:1; > - u32 ring:4; > + s32 ring:4; > u32 cache_level:2; > } *active_bo, *pinned_bo; > u32 active_bo_count, pinned_bo_count; Thanks, Paul --=-om7Pex5E2IwzGwwEp8rO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAk882A0ACgkQPX1aK2wOHVgC9QCfQUeueXwbaspazueXJNBbM69i iA0AnAjvFiDbOuHXoZ9MMccK+Z/jlhgx =4xdU -----END PGP SIGNATURE----- --=-om7Pex5E2IwzGwwEp8rO-- --===============0733484164== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0733484164==--