From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915: rc6 in sysfs Date: Tue, 10 Apr 2012 10:42:42 +0100 Message-ID: <1334050963_342611@CP5-2952> References: <1332899982-16324-1-git-send-email-ben@bwidawsk.net> <1332899982-16324-2-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 146759E8B3 for ; Tue, 10 Apr 2012 02:42:59 -0700 (PDT) In-Reply-To: <1332899982-16324-2-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Ben Widawsky , f@chad-versace.us, Arjan van de Ven , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Tue, 27 Mar 2012 18:59:39 -0700, Ben Widawsky wrote: > Merge rc6 information into the power group for our device. Until now the > i915 driver has not had any sysfs entries (aside from the connector > stuff enabled by drm core). Since it seems like we're likely to have > more in the future I created a new file for sysfs stubs, as well as the > rc6 sysfs functions which don't really belong elsewhere (perhaps > i915_suspend, but most of the stuff is in intel_display,c). > > displays rc6 modes enabled (as a hex mask): > cat /sys/class/drm/card0/power/rc6_enable > > displays #ms GPU has been in rc6 since boot: > cat /sys/class/drm/card0/power/rc6 > > displays #ms GPU has been in deep rc6 since boot: > cat /sys/class/drm/card0/power/rc6p > > displays #ms GPU has been in deepest rc6 since boot: > cat /sys/class/drm/card0/power/rc6pp Last comments, I promise. /sys/class/drm/card0/power/rc6_uptime_ms or /sys/class/drm/card0/power/rc6_total[_ms] or /sys/class/drm/card0/power/rc6_residency[_ms] A plain (rc6, rc6p, rc6pp) is just too vague and so may conflict with a future knob we wish to expose via sysfs. -Chris -- Chris Wilson, Intel Open Source Technology Centre