From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 2/4] drm/i915: clarify preferred sdvo input
	mode code
Date: Tue, 10 Apr 2012 13:18:13 +0100
Message-ID: <1334060295_345048@CP5-2952>
References: <1334058949-5633-1-git-send-email-daniel.vetter@ffwll.ch>
	<1334058949-5633-3-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <1334058949-5633-3-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, 10 Apr 2012 13:55:47 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> - kill intel_sdvo->input_dtd, it's only used as a temporary variable,
>   we store the preferred input mode in the adjusted mode at mode_fixup
>   time.
> - rename the function to make it clear what we want it to do (get the
>   preferred mode) and say in a comment what it unfortunately does as a
>   side-effect (set the new output timings).
> 
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Patches 2-4: Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre