From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 4/5] drm/i915: Always flush tiling changes before accessing through the GTT Date: Sat, 14 Apr 2012 22:59:25 +0100 Message-ID: <1334440777_831@CP5-2952> References: <1334393751-8921-1-git-send-email-chris@chris-wilson.co.uk> <1334393751-8921-4-git-send-email-chris@chris-wilson.co.uk> <20120414215452.GC4215@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 8548C9EF58 for ; Sat, 14 Apr 2012 14:59:40 -0700 (PDT) In-Reply-To: <20120414215452.GC4215@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, 14 Apr 2012 23:54:52 +0200, Daniel Vetter wrote: > On Sat, Apr 14, 2012 at 09:55:50AM +0100, Chris Wilson wrote: > > As we defer updating the fence register from set-tiling to the point of > > use, we need to declare every access through the GTT as either fenced or > > unfenced. > > > > This patches fixes up a couple of freshly introduced GTT accesses which > > missed the fence flush. > > > > Signed-off-by: Chris Wilson > > Actually no, this set_to_gtt is actually just a flush+wait_rendering > because the shmem pwrite/pread afters does clever in-line clflushing. > Abuse of interfaces, I know ... Probably best to leave a note, so the next time I do a grep looking for use of set-to-gtt without a following fence declaration, I don't submit another patch. :-) -Chris -- Chris Wilson, Intel Open Source Technology Centre