From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 6/9] drm/i915: [sparse] __iomem fixes for
	ringbuffer
Date: Mon, 16 Apr 2012 22:28:11 +0100
Message-ID: <1334611704_9673@CP5-2952>
References: <1334610468-9274-1-git-send-email-ben@bwidawsk.net>
	<1334610468-9274-7-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236])
	by gabe.freedesktop.org (Postfix) with ESMTP id 65FA29F675
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 16 Apr 2012 14:28:36 -0700 (PDT)
In-Reply-To: <1334610468-9274-7-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>, Ben Widawsky <benjamin.widawsky@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, 16 Apr 2012 14:07:45 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
>  	rem /= 8;
>  	while (rem--) {
> -		*virt++ = MI_NOOP;
> -		*virt++ = MI_NOOP;
> +		iowrite32(MI_NOOP, virt);
> +		virt+=4;
> +		iowrite32(MI_NOOP, virt);
> +		virt+=4;
Might as well use memset_io().
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre