From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/5] drm/i915: Suppress EIO during i915_gem_idle() Date: Wed, 18 Apr 2012 10:03:10 +0100 Message-ID: <1334739811_17664@CP5-2952> References: <1334393751-8921-1-git-send-email-chris@chris-wilson.co.uk> <1334393751-8921-3-git-send-email-chris@chris-wilson.co.uk> <20120418085129.GE5315@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id F2B68A0A72 for ; Wed, 18 Apr 2012 02:03:32 -0700 (PDT) In-Reply-To: <20120418085129.GE5315@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 18 Apr 2012 10:51:29 +0200, Daniel Vetter wrote: > On Sat, Apr 14, 2012 at 09:55:49AM +0100, Chris Wilson wrote: > > i915_gem_idle() is called when we need to suspend the GPU. If the GPU is > > already suspended by this point due to being wedged, we can safely > > continue. > > > > Signed-off-by: Chris Wilson > > Imo the right way to fix this case here is by checking this in gpu_idle > and just not bothering to emit any flushes and request if the gpu is > wedged already. Updated to fix i915_gpu_idle() instead. I don't want to add any more checks to dev->wedged though, as that I agree will become a nightmare. -Chris -- Chris Wilson, Intel Open Source Technology Centre