From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 11/12] drm/i915: Clarify the semantics of tiling-changed by renaming it Date: Wed, 18 Apr 2012 13:12:22 +0100 Message-ID: <1334751163_18715@CP5-2952> References: <1334673095-11771-1-git-send-email-chris@chris-wilson.co.uk> <1334673095-11771-12-git-send-email-chris@chris-wilson.co.uk> <20120418120502.GP5315@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id E96C39F601 for ; Wed, 18 Apr 2012 05:12:45 -0700 (PDT) In-Reply-To: <20120418120502.GP5315@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 18 Apr 2012 14:05:02 +0200, Daniel Vetter wrote: > On Tue, Apr 17, 2012 at 03:31:34PM +0100, Chris Wilson wrote: > > Rename obj->tiling_changed to obj->fence_change so that it is clear that > > it flags when the parameters for an active fence (including the > > no-fence) register are changed. > > > > Signed-off-by: Chris Wilson > > I've picked up all the patches for -next up to this one. Thanks a lot for > cleaning out the cruft here. For this patch I've got a bit confused about > fence_changed. Chris suggested fence_dirty on irc and I like it. I'm working on improving the comments here which will impact this and the next patch... -Chris -- Chris Wilson, Intel Open Source Technology Centre