From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: rc6 residency (fix the fix) Date: Fri, 20 Apr 2012 20:24:04 +0100 Message-ID: <1334949869_7667@CP5-2952> References: <1334947801-17280-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id C5E69A0F14 for ; Fri, 20 Apr 2012 12:24:38 -0700 (PDT) In-Reply-To: <1334947801-17280-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Ben Widawsky , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky wrote: > Chris' fix for my 32b breakage was incorrect. do_div returns a > remainder. Go back to a divide macro which is more 32b friendly. > > Tested on x86-64. > > This has only been compile tested on 32b systems. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48756 > Cc: Chris Wilson > Signed-off-by: Ben Widawsky Sincere-apologies: Chris Wilson Had I looked for the equivalent 64bit DIV_ROUND_UP, I could have saved myself some embarrassment. -Chris -- Chris Wilson, Intel Open Source Technology Centre