From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 09/10] drm/i915: wait render timeout ioctl Date: Sun, 22 Apr 2012 10:37:23 +0100 Message-ID: <1335087473_18597@CP5-2952> References: <1334971412-4826-1-git-send-email-ben@bwidawsk.net> <1334971412-4826-10-git-send-email-ben@bwidawsk.net> <1335001339_11300@CP5-2952> <20120421091217.0897735e@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 8F2119E73F for ; Sun, 22 Apr 2012 02:37:59 -0700 (PDT) In-Reply-To: <20120421091217.0897735e@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Sat, 21 Apr 2012 09:12:17 -0700, Ben Widawsky wrote: > On Sat, 21 Apr 2012 10:41:55 +0100 > Chris Wilson wrote: > > I think this whole interface is a stop-gap solution for pollable sync > > objects without a clear use case. Do we have a spec for a feature > > wishing to build upon this interface? > > Good point. This is primarily for glClientWaitSync. I will update the > commit message with this information. I read through the ARB_sync spec and this interface does seem to be a good match for that. A slight sour test from that spec being open-ended which might mean that we need to revise the interface in future. However, I did realise one blindingly obvious use-case: drm_intel_gem_bo_wait_wait_rendering(); Currently this is used by Mesa to do its client throttling, and in consequence also blocks X. i915_wait_ioctl() will allow mesa to only block itself and so help reduce interface stutters, even more important with multiple GL clients. -Chris -- Chris Wilson, Intel Open Source Technology Centre