From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 03/22] drm/i915: rip out GEM drm feature checks Date: Mon, 23 Apr 2012 23:28:46 +0100 Message-ID: <1335220155_31531@CP5-2952> References: <1335192669-10805-1-git-send-email-daniel.vetter@ffwll.ch> <1335192669-10805-4-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 109849E830 for ; Mon, 23 Apr 2012 15:29:21 -0700 (PDT) In-Reply-To: <1335192669-10805-4-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Mon, 23 Apr 2012 16:50:50 +0200, Daniel Vetter wrote: > We always set it so there's no point in checking. We could > instead add a bit that tells us whether gem is actually > initialized (i.e. either kms or gem_init_ioctl called), but > that's imho not worth it. > > So just rip it out. > > There's a little change in the wait_ring timeout, but we've never > run with anything else than the 60 second timeout, even on dri1 > userspace. No so much of a change as dead-code elimination. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre