From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 05/22] drm/i915: check for kms in dri1 ioctls Date: Mon, 23 Apr 2012 23:31:51 +0100 Message-ID: <1335220340_31543@CP5-2952> References: <1335192669-10805-1-git-send-email-daniel.vetter@ffwll.ch> <1335192669-10805-6-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id C17539E830 for ; Mon, 23 Apr 2012 15:32:27 -0700 (PDT) In-Reply-To: <1335192669-10805-6-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Mon, 23 Apr 2012 16:50:52 +0200, Daniel Vetter wrote: > Calling these when gem assumes full control of the hw won't end > in anything else than tears. So be a bit more paranoid here. > > Just serves as documentation. > > Signed-off-by: Daniel Vetter Having already killed do_init, I can't argue against these. Still ENODEV I think would be better. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre