From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 10/22] drm/i915: remove LP_RING&friends from modeset code Date: Mon, 23 Apr 2012 23:36:23 +0100 Message-ID: <1335220612_31562@CP5-2952> References: <1335192669-10805-1-git-send-email-daniel.vetter@ffwll.ch> <1335192669-10805-11-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 91986A01FD for ; Mon, 23 Apr 2012 15:36:59 -0700 (PDT) In-Reply-To: <1335192669-10805-11-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Mon, 23 Apr 2012 16:50:57 +0200, Daniel Vetter wrote: > The LP refers to 'low priority' as opposed to the high priority > ring on gen2/3. So lets constrain its use to the code of that era. > > Unfortunately we can't yet completely remove the associated > macros from common headers and shove them into i915_dma.c to > the other dri1 legacy support code, a few cleanups are still > missing for that. > > Signed-off-by: Daniel Vetter I'll on many occasions wished that the driver stopped shouting and consistently used intel_ring*, so Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre