From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: properly check for MODESET for kms driver ioctls Date: Tue, 24 Apr 2012 10:41:25 +0100 Message-ID: <1335260517_35734@CP5-2952> References: <1335255749_35096@CP5-2952> <1335254108-5130-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 3DFFA9E969 for ; Tue, 24 Apr 2012 02:42:02 -0700 (PDT) In-Reply-To: <1335254108-5130-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Tue, 24 Apr 2012 09:55:08 +0200, Daniel Vetter wrote: > Also ditch the cargo-culted dev_priv checks - either we have a > giant hole in our setup code or this is useless. Plainly bogus > to check for it in either case. > > v2: Chris Wilson noticed that I've missed one bogus dev_priv check. > > v3: The check in the overlay code is redundant (Chris) > > Signed-off-by: Daniel Vetter Never mind, intel_sprite.c goes through an idr to find its planes and not a simple pointer hanging off dev_priv. Speaking of which we never free the memory allocated for the planes... Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre