From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kamal Mostafa Subject: [PATCH 2/2] drm/i915: quirk disable i915 backlight on Dell XPS 13z Date: Wed, 25 Apr 2012 10:28:42 -0700 Message-ID: <1335374922-7905-2-git-send-email-kamal@canonical.com> References: <1335374922-7905-1-git-send-email-kamal@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 357A2A0E43 for ; Wed, 25 Apr 2012 10:28:56 -0700 (PDT) In-Reply-To: <1335374922-7905-1-git-send-email-kamal@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Robert Hooker List-Id: intel-gfx@lists.freedesktop.org From: Robert Hooker Dell XPS 13z exhibits problems (backlight flashing/pulsating) when intel_backlight is enabled at all, so disable it. BugLink: https://launchpad.net/bugs/954661 Signed-off-by: Robert Hooker Signed-off-by: Kamal Mostafa --- drivers/gpu/drm/i915/intel_display.c | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 5908cd5..0c4cac4 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9100,6 +9100,19 @@ static void quirk_ssc_force_disable(struct drm_device *dev) struct drm_i915_private *dev_priv = dev->dev_private; dev_priv->quirks |= QUIRK_LVDS_SSC_DISABLE; } + +/* + * Some machines (Dell XPS 13z) exhibit problems with i915 control of the + * backlight registers; Others may need the intel_backlight interface + * disabled for some other reason. + */ +static void quirk_backlight_disable(struct drm_device *dev) +{ + if (i915_enable_backlight == -1) { + i915_enable_backlight = 0; + DRM_DEBUG_DRIVER("disabling intel_backlight interface via quirk\n"); + } +} struct intel_quirk { int device; @@ -9133,6 +9146,10 @@ struct intel_quirk intel_quirks[] = { /* Sony Vaio Y cannot use SSC on LVDS */ { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable }, + + /* Dell XPS 13z needs to disable the intel_backlight interface + (LP: #954661) */ + { 0x0116, 0x1028, 0x052e, quirk_backlight_disable }, }; static void intel_init_quirks(struct drm_device *dev) -- 1.7.5.4