From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 11/12 v2] drm/i915: wait render timeout ioctl
Date: Fri, 27 Apr 2012 09:44:55 +0100
Message-ID: <1335516331_66033@CP5-2952>
References: <1335481389-7232-1-git-send-email-ben@bwidawsk.net>
	<1335481389-7232-12-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236])
	by gabe.freedesktop.org (Postfix) with ESMTP id 829E0A0E88
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 27 Apr 2012 01:45:42 -0700 (PDT)
In-Reply-To: <1335481389-7232-12-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 26 Apr 2012 16:03:08 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> +	mutex_unlock(&dev->struct_mutex);
> +	ret = __wait_seqno(ring, seqno, true, &timeout);
> +	drm_gem_object_unreference_unlocked(&obj->base);

Once we have the seqno to wait on, we can drop the reference to the
object. The reference to the ring will be persist whilst the device is
open. Just saves doing an unsightly unlock/lock dance in the unref.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre