From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915: Suppress hotplug work during PM
	suspend/resume
Date: Thu, 10 May 2012 11:12:58 +0100
Message-ID: <1336644799_224010@CP5-2952>
References: <s5hlilr4s9h.wl%tiwai@suse.de> <1334858104.32618.28.camel@atropine>
	<s5hty0f7frq.wl%tiwai@suse.de> <s5hd36w2pok.wl%tiwai@suse.de>
	<s5hehqswnlo.wl%tiwai@suse.de>
	<20120510082919.GA4867@phenom.ffwll.local>
	<s5hwr4kv36z.wl%tiwai@suse.de>
	<20120510090646.GD4867@phenom.ffwll.local>
	<s5h3978z94g.wl%tiwai@suse.de> <1336641962_223397@CP5-2952>
	<s5hy5p0xtlm.wl%tiwai@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236])
	by gabe.freedesktop.org (Postfix) with ESMTP id 62E709F50A
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 10 May 2012 03:13:22 -0700 (PDT)
In-Reply-To: <s5hy5p0xtlm.wl%tiwai@suse.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Takashi Iwai <tiwai@suse.de>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 10 May 2012 11:39:49 +0200, Takashi Iwai <tiwai@suse.de> wrote:
> At Thu, 10 May 2012 10:25:44 +0100,
> Chris Wilson wrote:
> > 
> > On Thu, 10 May 2012 11:19:11 +0200, Takashi Iwai <tiwai@suse.de> wrote:
> > > At Thu, 10 May 2012 11:06:46 +0200,
> > > Daniel Vetter wrote:
> > > > This patch is not just for hotplug, but for all the delayed work and timer
> > > > stuff the driver does. And we _do_ have a bug report that leaking the rps
> > > > work (for snb+ turbo mode) across either a s/r cycle or a gpu reset kills
> > > > the driver.
> > > 
> > > Yes, but my point is that Chris's patch (at least the commit above
> > > alone) won't fix the problem we faced.
> > 
> > The patch I thought you two were talking about was:
> > http://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=fastboot&id=a5f91dcc3cb7a9dc1214d5014ea6f0338824ad8e
> > which is what I thought we had planned to fix the residual issue.
> 
> Thanks, this explains better :)
> 
> But, as far as I checked, the hotplug event wasn't a leftover but
> newly triggered during the resume procedure.  Thus there is still a
> race even with the patch [drm/i915: Cancel outstanding modeset workers
> before suspend].

Which should be fixed with Adam's patch to only restore IRQs after doing
the modeset upon resume; if I am following all the threads of this bug
correctly.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre