From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kamal Mostafa Subject: Re: [PATCH 1/2] drm/i915: i915.enable_backlight=0 disables intel_backlight Date: Mon, 14 May 2012 11:53:50 -0700 Message-ID: <1337021630.8218.22.camel@fourier> References: <1335374922-7905-1-git-send-email-kamal@canonical.com> <20120426200729.GM5156@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1367071693==" Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by gabe.freedesktop.org (Postfix) with ESMTP id C99269E938 for ; Mon, 14 May 2012 11:53:57 -0700 (PDT) In-Reply-To: <20120426200729.GM5156@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org --===============1367071693== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-TnmxtucGf0uPE/ziTVLI" --=-TnmxtucGf0uPE/ziTVLI Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Daniel- Reminding you of this patch... The new i915.enable_backlight modparam introduced in patch 1/2 is generally useful, regardless of whether we quirk-enable as done in patch 2/2. Its already been used successfully for a different machine[0] with a different backlight problem. Please consider applying this patch 1/2. Thanks, -Kamal [0] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/954661/comments/27 On Thu, 2012-04-26 at 22:07 +0200, Daniel Vetter wrote: > On Wed, Apr 25, 2012 at 10:28:41AM -0700, Kamal Mostafa wrote: > > i915.enable_backlight=3D0 can be used to disable i915 backlight control > > and the /sys/class/backlight/intel_backlight interface -- useful for > > systems where intel_backight conflicts with BIOS backlight control. > >=20 > > BugLink: https://launchpad.net/bugs/954661 > > Signed-off-by: Kamal Mostafa >=20 > Ok, I've just gone through the fun of merging a set of backlight quirks a > few weeks back. Then noticed that an awful lot of machines seem to be > affected and later on read about a few interesting bits in the > documentation. Turns out the hw is all good, it's just the driver totally > mishandling the backlight. >=20 > To cut things short: This time around I want more justification for the > quirk than just "this makes this one machine work somehow". > -Daniel >=20 > > --- > > drivers/gpu/drm/i915/i915_drv.c | 6 ++++++ > > drivers/gpu/drm/i915/i915_drv.h | 1 + > > drivers/gpu/drm/i915/intel_panel.c | 12 ++++++++++++ > > 3 files changed, 19 insertions(+), 0 deletions(-) > >=20 > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i91= 5_drv.c > > index ae8a64f..ddb947b 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -112,6 +112,12 @@ module_param_named(i915_enable_ppgtt, i915_enable_= ppgtt, int, 0600); > > MODULE_PARM_DESC(i915_enable_ppgtt, > > "Enable PPGTT (default: true)"); > > =20 > > +int i915_enable_backlight __read_mostly =3D -1; > > +module_param_named(enable_backlight, i915_enable_backlight, int, 0644)= ; > > +MODULE_PARM_DESC(enable_backlight, > > + "Enable backlight control and the intel_backlight interface. " > > + "(default: -1 (auto))"); > > + > > static struct drm_driver driver; > > extern int intel_agp_enabled; > > =20 > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i91= 5_drv.h > > index 5fabc6c..6e52a42 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.h > > +++ b/drivers/gpu/drm/i915/i915_drv.h > > @@ -1087,6 +1087,7 @@ extern int i915_enable_rc6 __read_mostly; > > extern int i915_enable_fbc __read_mostly; > > extern bool i915_enable_hangcheck __read_mostly; > > extern int i915_enable_ppgtt __read_mostly; > > +extern int i915_enable_backlight __read_mostly; > > =20 > > extern int i915_suspend(struct drm_device *dev, pm_message_t state); > > extern int i915_resume(struct drm_device *dev); > > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/= intel_panel.c > > index 48177ec..fcecbd2 100644 > > --- a/drivers/gpu/drm/i915/intel_panel.c > > +++ b/drivers/gpu/drm/i915/intel_panel.c > > @@ -259,6 +259,9 @@ void intel_panel_disable_backlight(struct drm_devic= e *dev) > > { > > struct drm_i915_private *dev_priv =3D dev->dev_private; > > =20 > > + if (!i915_enable_backlight) > > + return; > > + > > dev_priv->backlight_enabled =3D false; > > intel_panel_actually_set_backlight(dev, 0); > > } > > @@ -267,6 +270,9 @@ void intel_panel_enable_backlight(struct drm_device= *dev) > > { > > struct drm_i915_private *dev_priv =3D dev->dev_private; > > =20 > > + if (!i915_enable_backlight) > > + return; > > + > > if (dev_priv->backlight_level =3D=3D 0) > > dev_priv->backlight_level =3D intel_panel_get_max_backlight(dev); > > =20 > > @@ -333,6 +339,9 @@ int intel_panel_setup_backlight(struct drm_device *= dev) > > struct backlight_properties props; > > struct drm_connector *connector; > > =20 > > + if (!i915_enable_backlight) > > + return 0; > > + > > intel_panel_init_backlight(dev); > > =20 > > if (dev_priv->int_lvds_connector) > > @@ -368,6 +377,9 @@ void intel_panel_destroy_backlight(struct drm_devic= e *dev) > > #else > > int intel_panel_setup_backlight(struct drm_device *dev) > > { > > + if (!i915_enable_backlight) > > + return; > > + > > intel_panel_init_backlight(dev); > > return 0; > > } > > --=20 > > 1.7.5.4 > >=20 > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx >=20 --=-TnmxtucGf0uPE/ziTVLI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABCAAGBQJPsVS+AAoJEHqwmdxYrXhZpQcP/1hPWwBmjD+U8l0W2EB/3Ou2 6h7fPFzDzDVAHL31r3ozQnK6U2BT9hWTb1pkdJWsXf0L5236RK3T3ZWIkzIGZvNL Mz5C25042S686QzLirU/gahAbk2fyfhL1mCUl3aZPky9tWtKa1ZJTCWFM4wX4mS1 19YQL15JM+e4mBYyfL57dx9qfbqDTFW+dOKHzhQyLcgrYd850gNoslwDst5g6wIo jju/HaAzhqdQymda1KSxlRt3xoAYjXProRxZYFyYzK7cS+k1s/29AISZ9IvCBpYX ez8tohqhwcM2mKNS22wBGJ36sxNVrGDFFGcnSTtingYo4XqjAOrSvXm2P4N68VTs RLR/aUlESuVmiQQwCYJUxq1Wkz5lexWWbnEDzJA86aUbTyxxpLqZD+H+SpttDWuu w8y+KFadT2Y0ntxcS/ZEWxibKes4lDs+WnmXcATgGYLYyhFk8RRl2O542mU1zgDI Ag+QbRoLJke+FIfAEQftgGmmruh+FJx2blU4/83eCCLJZpjSX4GDlbvCvdNsFF0I d10W43CMJJX2S6VjSqSOSGI70cIi8ms9h9H/SRPvzvAIBgfDU3TQAPcTf3+w07RS D/r9XIfJfds6VC2Gmuc/+MQSh770CbqxM7Q0ZfxE6bECpXQMb6Uanjg2R9mha7rv Sz+MJQazL8KleIspySjo =J98d -----END PGP SIGNATURE----- --=-TnmxtucGf0uPE/ziTVLI-- --===============1367071693== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1367071693==--