From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: clarify semaphore-ring interaction Date: Thu, 17 May 2012 14:09:28 +0100 Message-ID: <1337260170_80289@CP5-2952> References: <1337229612-12946-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B0549E91B for ; Thu, 17 May 2012 06:09:38 -0700 (PDT) In-Reply-To: <1337229612-12946-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Wed, 16 May 2012 21:40:12 -0700, Ben Widawsky wrote: > After Daniel split out this code, I think this makes more sense, and > looks nicer. Also added some comments to help the situation. > > Signed-off-by: Ben Widawsky The change is an improvement, just looks like it could be simplified... ;-p Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre