From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: fix up ivb plane 3 pageflips Date: Wed, 23 May 2012 13:05:35 +0100 Message-ID: <1337774750_201559@CP5-2952> References: <1337772653_201033@CP5-2952> <1337774520-26572-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id BC365A0949 for ; Wed, 23 May 2012 05:05:54 -0700 (PDT) In-Reply-To: <1337774520-26572-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Wed, 23 May 2012 14:02:00 +0200, Daniel Vetter wrote: > Or at least plug another gapping hole. Apparrently hw desingers only > moved the bit field, but did not bother ot re-enumerate the planes > when adding support for a 3rd pipe. > > Discovered by i-g-t/flip_test. > > This may or may not fix the reference bugzilla, because that one > smells like we have still larger fish to fry. > > v2: Fixup the impossible case to catch programming errors, noticed by > Chris Wilson. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=50069 > Signed-Off-by: Daniel Vetter The code looks correct, just not in a position atm to verify the MI_DISPLAY_FLIP bits. Acked-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre