Re: [PATCH 4/4] drm/i915: l3 parity sysfs interface

Daniel Vetter
2012-05-31T10:44:32Z

On Fri, May 25, 2012 at 04:56:25PM -0700, Ben Widawsky wrote:
> Dumb binary interfaces which allow root-only updates of the cache
> remapping registers. As mentioned in a previous patch, software using
> this interface needs to know about HW limits, and other programming
> considerations as the kernel interface does no checking for these things
> on the root-only interface.
>
> v1: Drop extra posting reads (Chris)
> Return negative values in the sysfs interfaces on errors (Chris)
>
> v2: Return -EINVAL for offset % 4 (Jesse)
> Move schizo userspace check out (Jesse)
> Cleaner sysfs item initializers (Daniel)
>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

I've queued this series for -next. Although you haven't fixed up the one
issue in patch 2 I've noticed and I also don't see my bikeshed for this
patch (despite that you claim to have done so). Whatever, I'll follow up
with patches.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48